From d8aa3e10398d0d23eefdbda899475ca32ec3abf6 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 7 May 2015 12:33:40 -0400 Subject: pylint 1.4.3 version fixes Pylint 1.4.3 completely stopped recognizing the star-args condition. In order to avoid pylint error with > 1.4.3 stop caring for star-args and add cmdline option to ignore those errors completly so older pylint versions are happy too. Also fix type() vs isinstance() checks, isinstance is generally a more correct approach to check for calsses. In some 'admin' files the type() -> isinstance() fix required to invert the order in which ComplexList and MappingList are checked as the latter is a subclass of ComplexList, so it needs to be checked first otherwise the check for isinstance(option, ComplexList) matches for both and the code stops funciotning properly. Signed-off-by: Simo Sorce --- Makefile | 2 ++ 1 file changed, 2 insertions(+) (limited to 'Makefile') diff --git a/Makefile b/Makefile index df6eb0f..c02b6ae 100644 --- a/Makefile +++ b/Makefile @@ -42,6 +42,7 @@ lint: pylint -d c,r,i,W0613 -r n -f colorized \ --notes= \ --ignored-classes=cherrypy,API \ + --disable=star-args \ ./ipsilon pep8: @@ -77,6 +78,7 @@ lp-test: pylint -d c,r,i,W0613 -r n -f colorized \ --notes= \ --ignored-classes=cherrypy \ + --disable=star-args \ ./tests pep8 tests -- cgit