summaryrefslogtreecommitdiffstats
path: root/ipsilon/login
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2014-10-05 13:33:16 -0400
committerPatrick Uiterwijk <puiterwijk@redhat.com>2014-10-06 19:53:08 +0200
commitdfd9e00ff07ebbf1c3e4d9ef525ba38e2e96739e (patch)
tree83407d369c35e1fdcf2990f3c54288b53030a9af /ipsilon/login
parentff1b48314db3c423db42f8ccbb8d371b5e6553b7 (diff)
downloadipsilon-dfd9e00ff07ebbf1c3e4d9ef525ba38e2e96739e.tar.gz
ipsilon-dfd9e00ff07ebbf1c3e4d9ef525ba38e2e96739e.tar.xz
ipsilon-dfd9e00ff07ebbf1c3e4d9ef525ba38e2e96739e.zip
Fix login session's userdata acquisition
With the transaction code changes th session.login() function was incorrectly moved before all the userdata was gathered. An incomplete set was stored in the session. Signed-off-by: Simo Sorce <simo@redhat.com> Reviewed-by: Patrick Uiterwijk <puiterwijk@redhat.com>
Diffstat (limited to 'ipsilon/login')
-rwxr-xr-xipsilon/login/common.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/ipsilon/login/common.py b/ipsilon/login/common.py
index 2b3ac19..3f44c15 100755
--- a/ipsilon/login/common.py
+++ b/ipsilon/login/common.py
@@ -45,7 +45,6 @@ class LoginManagerBase(PluginObject, Log):
def auth_successful(self, trans, username, auth_type=None, userdata=None):
session = UserSession()
- session.login(username, userdata)
if self.info:
userattrs = self.info.get_user_attrs(username)
@@ -61,6 +60,9 @@ class LoginManagerBase(PluginObject, Log):
else:
userdata = {'auth_type': auth_type}
+ # create session login including all the userdata just gathered
+ session.login(username, userdata)
+
# save username into a cookie if parent was form base auth
if auth_type == 'password':
cookie = SecureCookie(USERNAME_COOKIE, username)