summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRob Crittenden <rcritten@redhat.com>2015-03-16 16:39:02 -0400
committerRob Crittenden <rcritten@redhat.com>2015-03-16 16:54:15 -0400
commitbae1c5592da11f1fb2b9930730cf6acae942f3dc (patch)
tree0957be64c7164c6a2986ed2b2b60e02bc4bcb4f6
parente46c8f615f867d09ce76ee269b0ba81445ad320b (diff)
downloadipsilon-bae1c5592da11f1fb2b9930730cf6acae942f3dc.tar.gz
ipsilon-bae1c5592da11f1fb2b9930730cf6acae942f3dc.tar.xz
ipsilon-bae1c5592da11f1fb2b9930730cf6acae942f3dc.zip
Fix some pylint warnings in logout test about shadowing variables.
Signed-off-by: Rob Crittenden <rcritten@redhat.com> Reviewed-by: Nathan Kinder <nkinder@redhat.com>
-rwxr-xr-xtests/testlogout.py7
1 files changed, 4 insertions, 3 deletions
diff --git a/tests/testlogout.py b/tests/testlogout.py
index b8e2712..b192739 100755
--- a/tests/testlogout.py
+++ b/tests/testlogout.py
@@ -103,7 +103,7 @@ Alias /open ${HTTPDIR}/open
f.write(logged_out)
-def ensure_logout(sess, idpname, url):
+def ensure_logout(session, idp_name, spurl):
"""
Fetch the secure page without following redirects. If we get
a 303 then we should be redirected to the IDP for authentication
@@ -112,8 +112,9 @@ def ensure_logout(sess, idpname, url):
Returns nothing or raises exception on error
"""
try:
- page = sess.fetch_page(idpname, url, follow_redirect=False)
- if page.result.status_code != 303:
+ logout_page = session.fetch_page(idp_name, spurl,
+ follow_redirect=False)
+ if logout_page.result.status_code != 303:
raise ValueError('Still logged into url')
except ValueError:
raise