From 94a4d4947c41379fb74e229b1b0b00d554f170be Mon Sep 17 00:00:00 2001
From: Simo Sorce <simo@redhat.com>
Date: Wed, 3 Apr 2013 09:21:09 -0400
Subject: Fix locally dead code error found by coverity

By setting closewait to 0 after waitpid we would loop forever not the max 10
times we intended to.

Signed-off-by: Simo Sorce <simo@redhat.com>
---
 proxy/tests/interposetest.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'proxy/tests/interposetest.c')

diff --git a/proxy/tests/interposetest.c b/proxy/tests/interposetest.c
index 5912ec5..83e550d 100644
--- a/proxy/tests/interposetest.c
+++ b/proxy/tests/interposetest.c
@@ -857,7 +857,6 @@ static int run_cli_srv_test(int server_proxy_type,
             options = WNOHANG;
         }
         w = waitpid(-1, &status, options);
-        closewait = 0;
         if (w == cli) {
             cli = -1;
         } else if (w == srv) {
@@ -872,10 +871,10 @@ static int run_cli_srv_test(int server_proxy_type,
         if (closewait > 10) {
             ret = -1;
             goto done;
-        } else {
-            usleep(100000);
-            closewait++;
         }
+
+        usleep(100000);
+        closewait++;
     }
     ret = 0;
 
-- 
cgit