diff options
| author | Simo Sorce <simo@redhat.com> | 2013-06-25 16:07:42 -0400 |
|---|---|---|
| committer | Günther Deschner <gdeschner@redhat.com> | 2013-06-27 18:07:23 +0200 |
| commit | f66a585e042fbb2f313c1cbde329088fac86cea6 (patch) | |
| tree | 235f36862e97a302a4b0fc3c6c45e1b29d1d7080 /proxy/tests/scripts/dlopen.sh | |
| parent | 6cf727aad695466f45125bd30da5b2c2e2e9d48d (diff) | |
| download | gss-proxy-f66a585e042fbb2f313c1cbde329088fac86cea6.tar.gz gss-proxy-f66a585e042fbb2f313c1cbde329088fac86cea6.tar.xz gss-proxy-f66a585e042fbb2f313c1cbde329088fac86cea6.zip | |
Coverity fixes.
Fix a 4 coverity issues, ranging from memory leaks, to uninitialized
variables, to potential NULL derefernce.
Also a TOCTOU report that is in one of the accessory test scripts.
The bug itself is not reallya TOCTOU, but the check done in the script is
unecessary, so I just removed it.
Signed-off-by: Simo Sorce <simo@redhat.com>
Reviewed-by: Günther Deschner <gdeschner@redhat.com>
Diffstat (limited to 'proxy/tests/scripts/dlopen.sh')
| -rwxr-xr-x | proxy/tests/scripts/dlopen.sh | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/proxy/tests/scripts/dlopen.sh b/proxy/tests/scripts/dlopen.sh index 890cc39..1896a83 100755 --- a/proxy/tests/scripts/dlopen.sh +++ b/proxy/tests/scripts/dlopen.sh @@ -7,12 +7,10 @@ cat >> $tempdir/dlopen.c << _EOF #include <dlfcn.h> #include <stdio.h> #include <limits.h> -#include <sys/stat.h> /* Simple program to see if dlopen() would succeed. */ int main(int argc, char **argv) { int i; - struct stat st; char buf[PATH_MAX]; for (i = 1; i < argc; i++) { if (dlopen(argv[i], RTLD_NOW)) { @@ -20,7 +18,7 @@ int main(int argc, char **argv) argv[i]); } else { snprintf(buf, sizeof(buf), "./%s", argv[i]); - if ((stat(buf, &st) == 0) && dlopen(buf, RTLD_NOW)) { + if (dlopen(buf, RTLD_NOW)) { fprintf(stdout, "dlopen() of \"./%s\" " "succeeded.\n", argv[i]); } else { |