summaryrefslogtreecommitdiffstats
path: root/proxy/src/gp_init.c
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2013-04-03 09:57:24 -0400
committerSimo Sorce <simo@redhat.com>2013-04-03 16:39:11 -0400
commit2a7d19056d58344496fb24d90d0d02915ea83798 (patch)
tree17b620234f72e9497d0e131a083d2e059ec12425 /proxy/src/gp_init.c
parentb5fd9388baba101a3ae7b8a2f88164af2083a0a7 (diff)
downloadgss-proxy-2a7d19056d58344496fb24d90d0d02915ea83798.tar.gz
gss-proxy-2a7d19056d58344496fb24d90d0d02915ea83798.tar.xz
gss-proxy-2a7d19056d58344496fb24d90d0d02915ea83798.zip
Fix resource leaks found by Coverity
Signed-off-by: Simo Sorce <simo@redhat.com>
Diffstat (limited to 'proxy/src/gp_init.c')
-rw-r--r--proxy/src/gp_init.c7
1 files changed, 1 insertions, 6 deletions
diff --git a/proxy/src/gp_init.c b/proxy/src/gp_init.c
index f25adc4..6c17058 100644
--- a/proxy/src/gp_init.c
+++ b/proxy/src/gp_init.c
@@ -168,7 +168,6 @@ void init_proc_nfsd(struct gp_config *cfg)
GPDEBUG("Failed to write to %s: %d (%s)\n",
LINUX_PROC_USE_GSS_PROXY_FILE,
ret, strerror(ret));
- return;
}
ret = close(fd);
@@ -177,7 +176,6 @@ void init_proc_nfsd(struct gp_config *cfg)
GPDEBUG("Failed to close %s: %d (%s)\n",
LINUX_PROC_USE_GSS_PROXY_FILE,
ret, strerror(ret));
- return;
}
}
@@ -198,10 +196,8 @@ void write_pid(void)
}
ret = fprintf(f, "%d\n", pid);
- if (ret < 0) {
+ if (ret <= 0) {
GPDEBUG("Failed to write pid to %s\n", GP_PID_FILE);
- fclose(f);
- return;
}
ret = fclose(f);
@@ -209,6 +205,5 @@ void write_pid(void)
ret = errno;
GPDEBUG("Failed to close %s: %d (%s)\n",
GP_PID_FILE, ret, strerror(ret));
- return;
}
}