gss-proxy.git/proxy/src/client, branch review

Suppress warning: use after free

2015-03-29T21:34:42+00:00

gssx_ctx is released in case of error. After the latest changes,
the old ctx is always replaced to new one and output argument is set.

Although it would not be used because return code would not be success
it's safer to set NULL to the pointer and avoid warnings from static analyzers.

src/client/gpm_init_sec_context.c:108:
    alias: Assigning: "ctx" = "res->context_handle".
    Now both point to the same storage.
src/client/gpm_init_sec_context.c:156: freed_arg: "free" frees "ctx".
src/client/gpm_init_sec_context.c:173: use_after_free: Using freed pointer "ctx".

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Remove unused parameter from get_pipe_name

2015-03-29T21:32:01+00:00

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Properly handle security contexts on error

2015-03-24T15:49:25+00:00

On error we need to make sure we do not return a pointer to a
security context that may have been already freed.
So make sure to always unconditionally return the context that we've
been returned by our callees.
Also reorganize the code so we do not accidently wipe the context
and leak memoy on error.

This fixed a double-free bug found by NFS folks @ Red Hat

Fixes: https://fedorahosted.org/gss-proxy/ticket/137

Signed-off-by: Simo Sorce 
Reviewed-by: Nathaniel McCallum

Properly cleanup mutex on failure.

2014-03-12T13:03:44+00:00

If the call to create socket fails we leave a dangling lock and the client
enters into a deadlock on the next call.

Fixes: https://fedorahosted.org/gss-proxy/ticket/121

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Add zero termination when the buffer is a string

2014-01-15T14:00:03+00:00

This shouldn't be needed but apaprently there are a number of applications
like mod_auth_kerb that just blindly assume the out buffer returned by
gss_diplay_name() is a zero terminated string even though there is no
guarantee it is in the API. To avoid annoying misbehavior we forcibly zero
terminate strings copied and returned by the interposer.

Fixes: https://fedorahosted.org/gss-proxy/ticket/101

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Use gp_strerror() everywhere instead of strerror()

2013-11-22T13:41:24+00:00

https://fedorahosted.org/gss-proxy/ticket/111

Reviewed-by: Günther Deschner

Use secure_getenv in client and mechglue module

2013-11-21T12:48:25+00:00

proxymehc.so may be used in setuid binaries so follow best security
practices and use secure_getenv() if available.
Fallback to poorman emulation when secure_getenv() is not available.

Resolves: https://fedorahosted.org/gss-proxy/ticket/110

Reviewed-by: Günther Deschner

Fix continuations in context establishment calls

2013-11-19T13:34:47+00:00

Properly support continuations, including returning the rigth error code
and exporting partial contexts.

Fixes multistep authentications in particular for the initialization case
which always uses continuations.

Resolves: https://fedorahosted.org/gss-proxy/ticket/108

Reviewed-by: Günther Deschner

Preserve requested flags and lifetime

2013-11-19T13:02:42+00:00

These arguments have been accidentally forgotten causing failures for
applications that specify non default flags and non indefinite lifetime.

https://fedorahosted.org/gss-proxy/ticket/106

Reviewed-by: Günther Deschner

Fix resource leak in gpm_accept_sec_context().

2013-10-15T11:48:20+00:00

Resolves Coverity CID #12027.

Signed-off-by: Günther Deschner 
Reviewed-by: Simo Sorce