gss-proxy.git/proxy/src/client, branch delegate

Properly handle security contexts on error

2015-03-21T18:31:04+00:00

On error we need to make sure we do not return a pointer to a
security context that may have been already freed.
So make sure to always unconditionally return the context that we've
been returned by our callees.
Also reorganize the code so we do not accidently wipe the context
and leak memoy on error.

This fixed a double-free bug found by NFS folks @ Red Hat

Signed-off-by: Simo Sorce

Properly cleanup mutex on failure.

2014-03-12T13:03:44+00:00

If the call to create socket fails we leave a dangling lock and the client
enters into a deadlock on the next call.

Fixes: https://fedorahosted.org/gss-proxy/ticket/121

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Add zero termination when the buffer is a string

2014-01-15T14:00:03+00:00

This shouldn't be needed but apaprently there are a number of applications
like mod_auth_kerb that just blindly assume the out buffer returned by
gss_diplay_name() is a zero terminated string even though there is no
guarantee it is in the API. To avoid annoying misbehavior we forcibly zero
terminate strings copied and returned by the interposer.

Fixes: https://fedorahosted.org/gss-proxy/ticket/101

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Use gp_strerror() everywhere instead of strerror()

2013-11-22T13:41:24+00:00

https://fedorahosted.org/gss-proxy/ticket/111

Reviewed-by: Günther Deschner

Use secure_getenv in client and mechglue module

2013-11-21T12:48:25+00:00

proxymehc.so may be used in setuid binaries so follow best security
practices and use secure_getenv() if available.
Fallback to poorman emulation when secure_getenv() is not available.

Resolves: https://fedorahosted.org/gss-proxy/ticket/110

Reviewed-by: Günther Deschner

Fix continuations in context establishment calls

2013-11-19T13:34:47+00:00

Properly support continuations, including returning the rigth error code
and exporting partial contexts.

Fixes multistep authentications in particular for the initialization case
which always uses continuations.

Resolves: https://fedorahosted.org/gss-proxy/ticket/108

Reviewed-by: Günther Deschner

Preserve requested flags and lifetime

2013-11-19T13:02:42+00:00

These arguments have been accidentally forgotten causing failures for
applications that specify non default flags and non indefinite lifetime.

https://fedorahosted.org/gss-proxy/ticket/106

Reviewed-by: Günther Deschner

Fix resource leak in gpm_accept_sec_context().

2013-10-15T11:48:20+00:00

Resolves Coverity CID #12027.

Signed-off-by: Günther Deschner 
Reviewed-by: Simo Sorce

Fix socket error handling.

2013-05-16T10:11:43+00:00

1. Grab the socket lock for the whole conversation.

We need to keep the lock until the whole conversation is over.
Otherwise we may have concurrency issues where communication gets intermixed
and errors in one thread can cause a thread to hang.

Here is what we observed:

thread 1: grabs lock and send a request.
thread 2: grabs lock and sends a request
server: thread 2 request causes a fatal error and the server close the
connection
thread 2: grabs the lock and waits for a reply.
thread 2: gets the error and returns to caller with it (connection is closed).
thread 1: grabs the lock (which reopens the closed channel) and reads ...
... forever as the server has already killed all the previous state.

2. Fail immediately on short reads for the initial 4 byte length header.

If the first 4 bytes do not come at once don't bother retrying. In 99.9% of the
cases what we are witnessing here is a fatal error from the proxy that closed
the socket. Reopening the scket cannot accomplish anything as the request sent
down the channel is tied to the specific socket, so once the socket is closed
there is no hope to ever get back a reply.

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner

Add support for per-service sockets

2013-04-23T19:02:50+00:00

This way different processes running as the same user can be configured as
different servervices

Signed-off-by: Simo Sorce 
Reviewed-by: Günther Deschner