gss-proxy.git, branch review

Fix handling of context initialization

2015-03-29T21:42:08+00:00

If a previous call has decided to use only local (to the process)
credentials, then we need to override all the way to the end.

A previous patch also swapped the order in which credential handler
and context handler are initialized, make sure also to swap the
fallback checks.
Set the behavior to the process default only if it wasn't forced to
local.

Signed-off-by: Simo Sorce

Suppress warning: use after free

2015-03-29T21:34:42+00:00

gssx_ctx is released in case of error. After the latest changes,
the old ctx is always replaced to new one and output argument is set.

Although it would not be used because return code would not be success
it's safer to set NULL to the pointer and avoid warnings from static analyzers.

src/client/gpm_init_sec_context.c:108:
    alias: Assigning: "ctx" = "res->context_handle".
    Now both point to the same storage.
src/client/gpm_init_sec_context.c:156: freed_arg: "free" frees "ctx".
src/client/gpm_init_sec_context.c:173: use_after_free: Using freed pointer "ctx".

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Include header file with prototypes in implementation module

2015-03-29T21:33:28+00:00

Functions implemented in gp_util.c have prototypes in header file
gp_common.h, but it was not included. This patch prevent potential
conflicts between ptototype and definition of function.

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Remove unused parameter from get_pipe_name

2015-03-29T21:32:01+00:00

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Fix warning value stored to 'ret' is never read

2015-03-29T21:30:43+00:00

Error: UNUSED_VALUE
src/gp_rpc_import_and_canon_name.c:87:
    value_overwrite: Overwriting previous write to "ret" with value
    from "gp_conv_status_to_gssx(&icna->call_ctx, ret_maj, ret_min, mech,
                                 &icnr->status)".
src/gp_rpc_import_and_canon_name.c:52:
    assigned_value: Assigning value "22" to "ret" here, but that stored
    value is overwritten before it can be used.

Signed-off-by: Lukas Slebodnik 
Reviewed-by: Simo Sorce

Use pkg-config for krb5 libs too

2015-03-24T23:58:49+00:00

Signed-off-by: Simo Sorce

Switch to use pkg-config for krb5-gssapi

2015-03-24T22:14:34+00:00

Signed-off-by: Simo Sorce

Release version 0.4.0

2015-03-24T17:57:07+00:00

Signed-off-by: Simo Sorce

Suppress exported_composite_name for the kernel

2015-03-24T17:57:04+00:00

The kernel makes no use of this data, and ita causes allocation issues
in some cases with waste of space on the kernel side.

Fixes: https://fedorahosted.org/gss-proxy/ticket/129

Signed-off-by: Simo Sorce 
Reviewed-by: Nathaniel McCallum

Properly handle security contexts on error

2015-03-24T15:49:25+00:00

On error we need to make sure we do not return a pointer to a
security context that may have been already freed.
So make sure to always unconditionally return the context that we've
been returned by our callees.
Also reorganize the code so we do not accidently wipe the context
and leak memoy on error.

This fixed a double-free bug found by NFS folks @ Red Hat

Fixes: https://fedorahosted.org/gss-proxy/ticket/137

Signed-off-by: Simo Sorce 
Reviewed-by: Nathaniel McCallum