From bfb97d9d48c046c0e051dec9579dcb947b0c3668 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Wed, 16 Oct 2013 13:36:23 -0400 Subject: Fix handling of NULL domain Fix segafult in NTOWFv2. When domain is NULL it is just omitted from the NTOWFv2 computation. Fix segfault in accept_sec_context, just make dom_name be an empty string. Fix also memory leaks. --- src/gss_sec_ctx.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'src/gss_sec_ctx.c') diff --git a/src/gss_sec_ctx.c b/src/gss_sec_ctx.c index 7736244..528cb13 100644 --- a/src/gss_sec_ctx.c +++ b/src/gss_sec_ctx.c @@ -938,6 +938,15 @@ uint32_t gssntlm_accept_sec_context(uint32_t *minor_status, size_t ulen, dlen, uadlen; gss_buffer_desc usrname; + if (!dom_name) { + dom_name = strdup(""); + if (!dom_name) { + retmin = ENOMEM; + retmaj = GSS_S_FAILURE; + goto done; + } + } + ulen = strlen(usr_name); dlen = strlen(dom_name); if (ulen + dlen + 2 > 1024) { @@ -1075,6 +1084,9 @@ done: safefree(computer_name); safefree(workstation); safefree(domain); + safefree(usr_name); + safefree(dom_name); + safefree(wks_name); ntlm_free_buffer_data(&target_info); return retmaj; } -- cgit