From 1235dfa7bf4b249eb6da8eab8d8a2c7b0eef98db Mon Sep 17 00:00:00 2001 From: Petr Viktorin Date: Tue, 17 Apr 2012 12:42:35 -0400 Subject: Fail on unknown Command options When unknown keyword arguments are passed to a Command, raise an error instead of ignoring them. Options used when IPA calls its commands internally are listed in a new Command attribute called internal_options, and allowed. Previous patches (0b01751c, c45174d6, c5689e7f) made IPA not use unknown keyword arguments in its own commands and tests, but since that some violations were reintroduced in permission_find and tests. Fix those. Tests included; both a frontend unittest and a XML-RPC test via the ping plugin (which was untested previously). https://fedorahosted.org/freeipa/ticket/2509 --- tests/test_xmlrpc/test_host_plugin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests/test_xmlrpc/test_host_plugin.py') diff --git a/tests/test_xmlrpc/test_host_plugin.py b/tests/test_xmlrpc/test_host_plugin.py index 8798168af..69ef82e20 100644 --- a/tests/test_xmlrpc/test_host_plugin.py +++ b/tests/test_xmlrpc/test_host_plugin.py @@ -126,7 +126,7 @@ class test_host(Declarative): command=('host_add', [fqdn1], dict( description=u'Test host 1', - locality=u'Undisclosed location 1', + l=u'Undisclosed location 1', force=True, ), ), -- cgit