From 93332bcf4dd0189b7136db7fe4f900fc04171d20 Mon Sep 17 00:00:00 2001 From: Martin Basti Date: Wed, 6 Apr 2016 16:48:49 +0200 Subject: Remove unused variable and finally block in SchemaCache Handling exceptions in python is expensive operation, removing of uneeded finally block is good for performance. Reviewed-By: Stanislav Laznicka --- ipapython/ipaldap.py | 5 ----- 1 file changed, 5 deletions(-) (limited to 'ipapython') diff --git a/ipapython/ipaldap.py b/ipapython/ipaldap.py index 405f1ee2f..7e920e100 100644 --- a/ipapython/ipaldap.py +++ b/ipapython/ipaldap.py @@ -21,7 +21,6 @@ import time import datetime -import shutil from decimal import Decimal from copy import deepcopy import contextlib @@ -155,7 +154,6 @@ class SchemaCache(object): If a connection is provided then it the credentials bound to it are used. The connection is not closed when the request is done. """ - tmpdir = None assert conn is not None self.log.debug( @@ -184,9 +182,6 @@ class SchemaCache(object): # TODO: DS uses 'cn=schema', support for other server? # raise a more appropriate exception raise - finally: - if tmpdir: - shutil.rmtree(tmpdir) return ldap.schema.SubSchema(schema_entry[1]) -- cgit