From 602b395cf19b0ae0b8ade1c13ddaf09175ed7291 Mon Sep 17 00:00:00 2001 From: Christian Heimes Date: Wed, 15 Mar 2017 08:47:46 +0100 Subject: Fix Python 3 pylint errors ************* Module ipaserver.install.ipa_kra_install ipaserver/install/ipa_kra_install.py:25: [W0402(deprecated-module), ] Uses of a deprecated module 'optparse') ************* Module ipapython.install.core ipapython/install/core.py:163: [E1101(no-member), _knob] Module 'types' has no 'TypeType' member) ************* Module ipatests.test_ipapython.test_dn ipatests/test_ipapython/test_dn.py:1205: [W1505(deprecated-method), TestDN.test_x500_text] Using deprecated method assertEquals()) ************* Module ipa-ca-install install/tools/ipa-ca-install:228: [E1101(no-member), install_master] Instance of 'ValueError' has no 'message' member) install/tools/ipa-ca-install:232: [E1101(no-member), install_master] Instance of 'ValueError' has no 'message' member) Signed-off-by: Christian Heimes Reviewed-By: Simo Sorce Reviewed-By: Stanislav Laznicka --- ipapython/install/core.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'ipapython/install') diff --git a/ipapython/install/core.py b/ipapython/install/core.py index 1e4c36dce..919afa35c 100644 --- a/ipapython/install/core.py +++ b/ipapython/install/core.py @@ -11,7 +11,6 @@ import collections import functools import itertools import sys -import types import six @@ -24,6 +23,7 @@ __all__ = ['InvalidStateError', 'KnobValueError', 'Property', 'knob', 'Configurable', 'group', 'Component', 'Composite'] NoneType = type(None) +builtin_type = type # Configurable states _VALIDATE_PENDING = 'VALIDATE_PENDING' @@ -160,7 +160,7 @@ def _knob(type=_missing, default=_missing, bases=_missing, _order=_missing, if bases is _missing: bases = (KnobBase,) - elif isinstance(bases, types.TypeType): + elif isinstance(bases, builtin_type): bases = (bases,) if cli_names is None or isinstance(cli_names, str): -- cgit