From c3e3130a35f05348405701731ec2d5b85a772997 Mon Sep 17 00:00:00 2001 From: Lenka Doudova Date: Thu, 6 Oct 2016 10:54:07 +0200 Subject: Tests: Fix failing test_ipalib/test_parameters Parameters test fails because of KeyError caused by improper manipulation with kwargs in Param.__init__ method. During initialization, if kwargs['required'] or kwargs['multivalue'] is None, it is delete from dictionary and hence the missing key. Small change of the condition prevents this from happening. Partially fixes https://fedorahosted.org/freeipa/ticket/6292 Reviewed-By: Martin Babinsky --- ipalib/parameters.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'ipalib/parameters.py') diff --git a/ipalib/parameters.py b/ipalib/parameters.py index 77a6136cf..32ff9a8df 100644 --- a/ipalib/parameters.py +++ b/ipalib/parameters.py @@ -473,7 +473,7 @@ class Param(ReadOnly): CALLABLE_ERROR % (key, value, type(value)) ) kw[key] = value - else: + elif key not in ('required', 'multivalue'): kw.pop(key, None) # We keep these values to use in __repr__(): -- cgit