From cad9f9b682d9bcc33fdfb1112e4cfb1a2c66a498 Mon Sep 17 00:00:00 2001 From: Pavel Vomacka Date: Mon, 25 Jul 2016 18:25:36 +0200 Subject: Coverity - null pointer dereference The 'obj' variable could be null, so there could be error when it is used. A new check that 'obj' is not false is added. Reviewed-By: Petr Vobornik --- install/ui/src/freeipa/widgets/browser_widgets.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/install/ui/src/freeipa/widgets/browser_widgets.js b/install/ui/src/freeipa/widgets/browser_widgets.js index 57ad2bd98..91bb850a6 100644 --- a/install/ui/src/freeipa/widgets/browser_widgets.js +++ b/install/ui/src/freeipa/widgets/browser_widgets.js @@ -427,11 +427,11 @@ widgets.browser_widgets.CommandDetailWidget = declare([base], { if (i>0) { out_params_cnt.append(', '); } - if (!param) { - out_params_cnt.append(param_name); - } else { + if (param && obj) { var link = this.render_param_link(obj.name, param_name); out_params_cnt.append(link); + } else { + out_params_cnt.append(param_name); } } out_params_cnt.appendTo(this.el); -- cgit