summaryrefslogtreecommitdiffstats
path: root/install/ui
Commit message (Collapse)AuthorAgeFilesLines
...
* Coverity - iterating over variable which could be nullPavel Vomacka2016-11-101-4/+4
| | | | | | Change condition to check also variable which could be null. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - null pointer dereferencePavel Vomacka2016-11-101-3/+3
| | | | | | | The 'obj' variable could be null, so there could be error when it is used. A new check that 'obj' is not false is added. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - true branch can't be executedPavel Vomacka2016-11-101-1/+2
| | | | | | | The 'result' variable is always false because of previous condition. Therefore there is direct assignment. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - true branch can't be executedPavel Vomacka2016-11-101-1/+2
| | | | | | | The 'data' variable is always false because of previous condition. Therefore there is direct assignment. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - removed dead codePavel Vomacka2016-11-101-12/+8
| | | | | | There cannot be string value because of previous checks. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - Accesing attribute of nullPavel Vomacka2016-11-101-1/+1
| | | | | | | There is a possibility that widget is null and then there could be an error. Therefore there is new check of widget variable. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - identical code for different branchesPavel Vomacka2016-11-101-2/+2
| | | | | | | In both cases when the condition is true or false ut is set the same value. Changed to assign the value directly. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - not initialized variablePavel Vomacka2016-11-101-1/+1
| | | | | | The variable hasn't been initialized, now it is set to null by default. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - null pointer exceptionPavel Vomacka2016-11-101-0/+2
| | | | | | | Variable 'row' could be null in some cases. And set css to variable which is pointing to null causes error. Therefore there is new check. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Coverity - null pointer exceptionPavel Vomacka2016-11-101-1/+1
| | | | | | Variable 'option' can be null and there will be error of reading property of null. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Build: fix make clean for web UIPetr Spacek2016-11-092-0/+4
| | | | | | | https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Web UI: Remove offline version of Web UIPetr Spacek2016-11-094-4/+0
| | | | | | | | | | | The offline version does not work for some time already. I'm removing it right now to get rid of garbage which clutters build system. https://fedorahosted.org/freeipa/ticket/6447 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Build: fix distribution of static files for web UIPetr Spacek2016-11-097-4/+17
| | | | | | | | | | | | | | | | Static files from Git which are not touched by the build system have to be explicitly listed in Makefile.am so they get into tarball. EXTRA_DIST lists whole sub-directories with static files. This is not ideal but we do not have enough time to fix it properly. Dojo builder patch files were renames to shorten their name. The original names were exceeding autotools length limit. https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Build: stop build when a step in web UI build failsPetr Spacek2016-11-0911-6/+17
| | | | | | | https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Build: fix Makefile.am files to separate source and build directoriesPetr Spacek2016-11-092-2/+2
| | | | | | | | | | | | | This is step forward working VPATH builds which cleanly separate sources and build artifacts. It makes the system cleaner and easier to understand. Python and web UI likely require more work to make VPATH builds working. https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* Build: move version handling from Makefile to configurePetr Spacek2016-11-091-3/+3
| | | | | | | | | | | | | | | Version information is now in VERSION.m4 instead of VERSION. Makefile target version-update was minimized and configure can be run before make. Makefile temporarily contains hardcoded version which has to match the one specified in VERSION.m4. This is preparatory step which will allow us to replace hand-made Makefile with one generated by Automake. https://fedorahosted.org/freeipa/ticket/6418 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com>
* WebUI: services without canonical name are shown correctlyPavel Vomacka2016-10-312-1/+92
| | | | | | | | | | | | | There is a change introduced in 4.4 that new services have canonical name. The old ones didn't have it, therefore these services were not correctly displayed in WebUI. This patch adds support for this type of services. Service name is taken from 'krbprincipalname' attribute in case that 'krbcanonicalname' attribute is not present in server response. https://fedorahosted.org/freeipa/ticket/6397 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Do not create Object Signing certificateFraser Tweedale2016-10-261-7/+1
| | | | | | | | | | The Object Signing certificate created during server installation was used only for signing the (recently removed) Firefox extension, so there's no need to create that certificate any more. Fixes: https://fedorahosted.org/freeipa/ticket/6399 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* WebUI: fix API Browser menu labelPavel Vomacka2016-10-112-1/+2
| | | | | | | | | The label of API Browser is now in translatable strings and it has uppercase B at the beginnig of second word. https://fedorahosted.org/freeipa/ticket/6384 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Add tooltip to all fields in DNS record adder dialogPavel Vomacka2016-10-111-0/+15
| | | | | | In case that option is not documented or the doc string is the same as label, then no tooltip is shown. Reviewed-By: Martin Basti <mbasti@redhat.com>
* DNS: Improve field descriptions for SRV recordsPetr Spacek2016-10-111-4/+4
| | | | Reviewed-By: Martin Basti <mbasti@redhat.com>
* DNS: Support URI resource record typePetr Spacek2016-10-111-1/+14
| | | | | | https://fedorahosted.org/freeipa/ticket/6344 Reviewed-By: Martin Basti <mbasti@redhat.com>
* WebUI: hide buttons in certificate widget according to aclPavel Vomacka2016-09-292-1/+58
| | | | | | | | | | | | | When user is logged in and opens details page of another user there should not be visible button for adding new certificate and also the option in action menu for deleting certificate should be grayed out. This is achieved by adding custom field for certificates widget, which is able to read ACLs from result of user-show and not from cert-find result. https://fedorahosted.org/freeipa/ticket/6341 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Added a fix for setting Priority as required field in Password Policy ↵Abhijeet Kasurde2016-09-211-1/+4
| | | | | | | | | Details facet Fixes: https://fedorahosted.org/freeipa/ticket/6335 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* WebUI: Change group name from 'normal' to 'Non-POSIX'Pavel Vomacka2016-09-212-8/+6
| | | | | | | | It will correspond with CLI and will be more self-explanatory. https://fedorahosted.org/freeipa/ticket/6334 Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* WebUI: Add handling for HTTP error 404Pavel Vomacka2016-09-151-1/+8
| | | | | | | | | | In case that API is not accessible the 404 error is thrown. There was error dialog with almost no information. The new dialog says what error is there and what can be the main cause of the error. https://fedorahosted.org/freeipa/ticket/4821 Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* Add 'Restore' option to action dropdown menuPavel Vomacka2016-09-083-9/+35
| | | | | | | | Also moving activate_action method several lines up - correcting logical order of methods. https://fedorahosted.org/freeipa/ticket/5818 Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* WebUI add support for sub-CAs while revoking certificatesPavel Vomacka2016-09-072-30/+100
| | | | | | | | | Also the same for removing certificate hold. https://fedorahosted.org/freeipa/ticket/6216 Reviewed-By: Petr Vobornik <pvoborni@redhat.com> Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* WebUI: Fix showing certificates issued by sub-CAPavel Vomacka2016-09-071-0/+7
| | | | | | | | | The cert-show command needs to be called with cacn option. Cacn option is passed using URL attribute. https://fedorahosted.org/freeipa/ticket/6238 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add support for additional options taken from table facetPavel Vomacka2016-09-071-1/+48
| | | | | | | | | | | | | | Sometimes the entity_show command must be called with options which are gathered from result of entity_find command. These options needs to be passed as arguments in URL which points to details page. This functionality is implemented to table facet. There is new property 'additional_navigation_arguments' which is prepared for array of attributes which will be passed to URL. Part of: https://fedorahosted.org/freeipa/ticket/6238 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Removed unwanted line break from RefererError Dialog messageAbhijeet Kasurde2016-08-231-1/+1
| | | | | | | Fixes: https://fedorahosted.org/freeipa/ticket/5932 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com> Reviewed-By: Martin Basti <mbasti@redhat.com>
* Add 'trusted to auth as user' checkboxPavel Vomacka2016-08-172-0/+10
| | | | | | | | Add new checkbox to host and service details page Prerequisite for: https://fedorahosted.org/freeipa/ticket/5764 Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* Set servers list as default facet in topology facet groupPavel Vomacka2016-08-171-1/+1
| | | | | | | | | | Since there is a new warning about only one CA server, the default facet of topology facet group is set to servers list where the warning is. So the warning will be shown right after clicking on Topology section. Part of: https://fedorahosted.org/freeipa/ticket/5828 Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
* Add warning about only one existing CA serverPavel Vomacka2016-08-172-1/+74
| | | | | | | | | | It is not safe to have only one CA server in topology. Therefore there is a check and in case that there is only one CA server a warning is shown. The warning is shown after each refreshing of servers facet. https://fedorahosted.org/freeipa/ticket/5828 Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
* Fix unicode characters in ca and domain addersPavel Vomacka2016-08-091-1/+3
| | | | | | | | | | | | Topology graph didn't show plus icons correctly. There is a problem with uglifying of javascript code. It does not leave unicode character written in hexadecimal format unchanged. Therefore this workaround which inserts needed character using Javascript function and uglifiyng does not affect it. https://fedorahosted.org/freeipa/ticket/6175 Reviewed-By: Martin Basti <mbasti@redhat.com>
* Remove full name from adding user to user group dialogPavel Vomacka2016-07-281-6/+1
| | | | | | | | | As the 'cn' is not in the response of user-show there is empty column in adder dialog. Therefore the column was removed. https://fedorahosted.org/freeipa/ticket/6055 Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
* Close host adder dialog before showing 4304 dialogPavel Vomacka2016-07-271-0/+1
| | | | | | | | The adder dialog window stayed opened but not visible. This patch closes it. https://fedorahosted.org/freeipa/ticket/6050 Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
* Add widget for kerberos aliases to service pagePavel Vomacka2016-07-011-5/+12
| | | | | | | | | Also changes the name of option which is send during adding new service from 'krbprincipalname' to 'krbcanonicalname'. https://fedorahosted.org/freeipa/ticket/5927 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add widget for kerberos aliases to hosts pagePavel Vomacka2016-07-011-1/+8
| | | | | | https://fedorahosted.org/freeipa/ticket/5927 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add widget for kerberos aliases to user pagePavel Vomacka2016-07-011-1/+8
| | | | | | https://fedorahosted.org/freeipa/ticket/5927 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add widgets for kerberos aliasesPavel Vomacka2016-07-012-0/+114
| | | | | | | | Create own custom_command_multivalued_widget for kerberos aliases. https://fedorahosted.org/freeipa/ticket/5927 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Set default confirmation button label to 'Remove'Pavel Vomacka2016-07-011-1/+2
| | | | | | Part of: https://fedorahosted.org/freeipa/ticket/5831 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Change error handling in custom_command_multivalued_widgetPavel Vomacka2016-07-011-3/+11
| | | | | | | | | | | The custom_command_multivalued_widget now handles remove and add commands errors correctly and shows error message. Part of: https://fedorahosted.org/freeipa/ticket/5381 add_error Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* webui: prevent infinite reload for users with krbbprincipal alias setPetr Vobornik2016-07-011-1/+5
| | | | | | | | | | | | | | | | | | Web UI has inbuilt mechanism to reload in case response from a server contains a different principal than the one loaded during Web UI startup. see rpc.js:381 With kerberos aliases support the loaded principal could be different because krbprincipalname contained multiple values. In such case krbcanonicalname should be used - it contains the same principal as the one which will be in future API responses. https://fedorahosted.org/freeipa/ticket/5927 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Add button for server-del commandPavel Vomacka2016-06-302-1/+68
| | | | | | WebUI counterpart of: https://fedorahosted.org/freeipa/ticket/5588 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add support to change button css class on confirm dialogPavel Vomacka2016-06-301-0/+11
| | | | | | Part of: https://fedorahosted.org/freeipa/ticket/5588 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Simplify the confirmation messagesPavel Vomacka2016-06-301-2/+2
| | | | | | | | | The confirmation of revoke and remove the certificate hold action is simplier and more consistent with another parts of WebUI. Part of: https://fedorahosted.org/freeipa/ticket/5381 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Change paths of strings in auth indicators widget on service pagePavel Vomacka2016-06-301-3/+3
| | | | | | | | | Strings which are used by widget which shows authentication indicators were moved. Therefore the change in string paths. Part of: https://fedorahosted.org/freeipa/ticket/5872 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add authentication identificator to host pagePavel Vomacka2016-06-302-3/+23
| | | | | | | | | | Also move strings which are connected with authentication indicators to authtype dict. This place is more general than have them in service dict. It's nicer when these strings are not used only on service page. Part of: https://fedorahosted.org/freeipa/ticket/5872 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
* Add certificate widget to ID override user details page.Pavel Vomacka2016-06-291-1/+167
| | | | | | | | Add possibility to add, remove, view, get and download custom certificates on ID override user page. https://fedorahosted.org/freeipa/ticket/5926 Reviewed-By: Petr Vobornik <pvoborni@redhat.com>