summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Pretty-print structures in assert_deepequalStanislav Laznicka2016-09-303-7/+37
| | | | | | | | | | | By default, ipa-run-tests will now pretty-print structures compared in the assert_deepequal function. This behaviour can be turned off by the --no-pretty-print option. https://fedorahosted.org/freeipa/ticket/6212 Reviewed-By: Martin Basti <mbasti@redhat.com> Reviewed-By: Petr Spacek <pspacek@redhat.com>
* WebUI: hide buttons in certificate widget according to aclPavel Vomacka2016-09-292-1/+58
| | | | | | | | | | | | | When user is logged in and opens details page of another user there should not be visible button for adding new certificate and also the option in action menu for deleting certificate should be grayed out. This is achieved by adding custom field for certificates widget, which is able to read ACLs from result of user-show and not from cert-find result. https://fedorahosted.org/freeipa/ticket/6341 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* Pylint: enable check for unused-variablesMartin Basti2016-09-2768-1/+130
| | | | | | | | | | | | | | | Unused variables may: * make code less readable * create dead code * potentialy hide issues/errors Enabled check should prevent to leave unused variable in code Check is locally disabled for modules that fix is not clear or easy or have too many occurences of unused variables Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com> Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* Remove unused variables in testsMartin Basti2016-09-2742-111/+93
| | | | | | | | This commit removes or marks unused variables as "expected to be unused" by using '_' prefix. Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com> Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* Remove unused variables in the codeMartin Basti2016-09-2747-69/+54
| | | | | | | | | | | This commit removes unused variables or rename variables as "expected to be unused" by using "_" prefix. This covers only cases where fix was easy or only one unused variable was in a module Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com> Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
* test_text: add test ipa.pot file for testsMartin Basti2016-09-263-5/+54
| | | | | | | | | Input data should be packaged into freeipa-test module to be able run test from RPM (outoftree) https://fedorahosted.org/freeipa/ticket/6333 Reviewed-By: Lenka Doudova <ldoudova@redhat.com>
* Prompt for forwarder in dnsforwardzone-addTomas Krizek2016-09-261-0/+5
| | | | | | | | | | When the command ipa dnsforwardzone-add is invoked without specifying the forwarder as an argument and the forward policy is not set to none, prompt for DNS forwarder. https://fedorahosted.org/freeipa/ticket/6169 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* Make Continuous installer continuous only during execution phaseMartin Babinsky2016-09-262-6/+3
| | | | | | | | | | | | | | `common.Continuous` class is a basis for uninstallers, which should execute all the steps regardless of occuring errors. However, we would like the installer to raise exceptions and return non-zero exit code during validation phase when some preconditions are not met. Add a separate exception handler which catches exceptions and logs them as errors during execution phase only. https://fedorahosted.org/freeipa/ticket/5725 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* use separate exception handlers for executors and validatorsMartin Babinsky2016-09-261-4/+18
| | | | | | | | | installer framework has been modified to allow for different error handling during validation and execution phases. https://fedorahosted.org/freeipa/ticket/5725 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* Update man/help for --server optionTomas Krizek2016-09-235-5/+6
| | | | | | | | | The --server option now specifically mentions that it expects the FQDN of the IPA server. https://fedorahosted.org/freeipa/ticket/6202 Reviewed-By: Petr Spacek <pspacek@redhat.com>
* sudorule: add SELinux transition examples to plugin docFraser Tweedale2016-09-231-0/+4
| | | | | | | | | It is not obvious how to add SELinux type and role transitions to a Sudo rule. Update the 'sudorule' plugin documentation with examples of how to do this. Fixes: https://fedorahosted.org/freeipa/ticket/3461 Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
* Pylint: enable global-variable-not-assigned checkMartin Basti2016-09-236-15/+3
| | | | | | | the global keyword should be used only when variable from outside is assigned inside, otherwise it has no effect and just confuses developers Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
* Pylint: enable cyclic-import checkMartin Basti2016-09-231-1/+0
| | | | | | | It looks that pylint stopped printing false positive errors for cyclic-import check, thus check can be enabled. Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
* Fix cert revocation when removing all certs via host/service-modFraser Tweedale2016-09-232-2/+4
| | | | | | | | | | | When removing all host/service certificates via host/service-mod --certificate=, the removed certificates should be revoked, but they are not. Examine whether the --certificate option was provided to determine whether certs should be revoked, instead of looking for a cert list in the options (which in this case is empty). Fixes: https://fedorahosted.org/freeipa/ticket/6305 Reviewed-By: Jan Cholasta <jcholast@redhat.com>
* pylint: fix bad-mcs-method-argumentJan Barta2016-09-222-25/+24
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix bad-mcs-classmethod-argumentJan Barta2016-09-222-3/+2
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix bad-classmethod-argumentJan Barta2016-09-222-3/+2
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix old-style-classJan Barta2016-09-228-9/+12
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix redefine-in-handlerJan Barta2016-09-223-13/+12
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix pointless-statementJan Barta2016-09-223-13/+12
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix unneeded-notJan Barta2016-09-2211-15/+14
| | | | | Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* pylint: fix simplifiable-if-statement warningsJan Barta2016-09-229-55/+15
| | | | | | | fix inefficient if statements, enable pylint check Reviewed-By: Tomas Krizek <tkrizek@redhat.com> Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
* Test: dont use global variable for iteration in test_cert_pluginMartin Basti2016-09-221-1/+3
| | | | | | | | | Iteration over global variable causes unwanted value changes outside method https://fedorahosted.org/freeipa/ticket/5755 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
* tests: Fixed code styling in caless tests to make pep8 happyOleg Fayans2016-09-221-7/+7
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Reverted erroneous asserts in 4 testsOleg Fayans2016-09-221-10/+4
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: fixed certinstall methodOleg Fayans2016-09-221-3/+1
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: fixed super method invocationOleg Fayans2016-09-221-1/+1
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: added verbose assert to test_service_disable_doesnt_revokeOleg Fayans2016-09-221-2/+5
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Standardized replica_preparation in test_no_certsOleg Fayans2016-09-221-4/+2
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Implemented check for domainlevel before installation verificationOleg Fayans2016-09-221-43/+18
| | | | | | | We only need to verify installation of replica under domain level 1, otherwise replica is not installed but only a gpg file is prepared Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Fixed Usage of improper certs in ca-less testsOleg Fayans2016-09-221-15/+12
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: fixed expects of incorrect error messagesOleg Fayans2016-09-221-32/+24
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Replaced unused setUp method with installOleg Fayans2016-09-221-7/+7
| | | | | | | setUp method does not get executed in recent versions of pytest Replaced with the install method derived from the parent IntegrationTest class Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Replaced hardcoded certutil with imported from pathsOleg Fayans2016-09-221-1/+1
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Enabled negative testing for cleaning replication agreementsOleg Fayans2016-09-221-5/+6
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Made unapply_fixes call optional at master uninstallationOleg Fayans2016-09-221-2/+3
| | | | | | | | | Unapply fixes removes the temporary testing folder at ~/ipatests, which contains some artifacts like root.pem that need to be persistent between tests in the test_caless testsuite. There has to be the way to skip the deletion of this testfolder Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Updated master and replica installation methods to enable negative ↵Oleg Fayans2016-09-221-40/+54
| | | | | | | | | | testing Negative testing was enabled by introducing an optional raiseonerr parameter with True by default to both master and replica installation methods Also the methods were updated to support intractive installation Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Added necessary xfailsOleg Fayans2016-09-221-0/+13
| | | | | | A number of tests fail due to known issues. Added xfails to acknowledge them Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Added necessary getkeytabs calls to fixturesOleg Fayans2016-09-221-0/+7
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Removed outdated command options testOleg Fayans2016-09-221-19/+0
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Applied correct teardown methodsOleg Fayans2016-09-221-15/+56
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Fixed incorrect assert in verify_installationOleg Fayans2016-09-221-3/+1
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Adapted installation methods to utilize methods from tasksOleg Fayans2016-09-221-93/+57
| | | | | | | Master and replica installation methods were made to utilize corresponding methods from tasks.py for the sake of DRY Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Removed call for install method from parent classOleg Fayans2016-09-221-1/+0
| | | | | | | | The IntegrationTest.install method installs the full topology while in ca-less tests we need to check server installation, thus the nodes should not have server or replica installed Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Added teardown methods for server and replica installationOleg Fayans2016-09-221-0/+35
| | | | Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Create a method that cleans all ipa certsOleg Fayans2016-09-221-0/+11
| | | | | | | | | | Upon uninstallation IPA does not remove certs from the system, see https://fedorahosted.org/freeipa/ticket/4639 for details. This causes installation failures in several tests. The workaround is to manually remove certs from all certificate databases used by IPA after each server uninstallation Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Updated ipa server installation stdin textOleg Fayans2016-09-221-4/+0
| | | | | | | The installator has changed the question sequence so the stdin used for interactive server installation has to be changed accordingly Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Added generation of missing certsOleg Fayans2016-09-221-0/+3
| | | | | | | test_ca_server_cert and test_unknown_ca required 2 more certs that were not pre-generated Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Added basic constraints extension to the CA certsOleg Fayans2016-09-221-1/+4
| | | | | | | The IPA installer refuses to accept certs signed with a CA-signature that does not have basic constraints enabled (Described in RFC 5280) Reviewed-By: David Kupka <dkupka@redhat.com>
* tests: Fixed method failures during second call for the methodOleg Fayans2016-09-221-1/+2
| | | | | | | | | | | | | When the same host is used for numerous server/replica installations/uninstallations at some point the /etc/openldap/ldap.conf file gets corruped which results in ldapsearch unaware of the default ldap_uri to connect. The workaround would be to provide ldap hostname for each ldapsearch. Attention: please unapply this fix once the original issue is resolved. https://fedorahosted.org/freeipa/ticket/5880 Reviewed-By: David Kupka <dkupka@redhat.com>
generated by cgit (git 2.34.1) at 2025-09-29 06:41:43 +0000