diff options
| author | Fraser Tweedale <ftweedal@redhat.com> | 2016-11-15 14:02:54 +1000 |
|---|---|---|
| committer | Martin Basti <mbasti@redhat.com> | 2016-12-14 18:08:33 +0100 |
| commit | fec4c32ff15a96736740cf7d2f713a21af0b227e (patch) | |
| tree | f6966c603ef45eadb460ccfe71299469443feabb /ipaserver/plugins | |
| parent | 397f2be9dfd6475127742c0b710b37b443d97d67 (diff) | |
| download | freeipa-fec4c32ff15a96736740cf7d2f713a21af0b227e.tar.gz freeipa-fec4c32ff15a96736740cf7d2f713a21af0b227e.tar.xz freeipa-fec4c32ff15a96736740cf7d2f713a21af0b227e.zip | |
certprofile-mod: correctly authorise config update
Certificate profiles consist of an FreeIPA object, and a
corresponding Dogtag configuration object. When updating profile
configuration, changes to the Dogtag configuration are not properly
authorised, allowing unprivileged operators to modify (but not
create or delete) profiles. This could result in issuance of
certificates with fraudulent subject naming information, improper
key usage, or other badness.
Update certprofile-mod to ensure that the operator has permission to
modify FreeIPA certprofile objects before modifying the Dogtag
configuration.
https://fedorahosted.org/freeipa/ticket/6560
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Diffstat (limited to 'ipaserver/plugins')
| -rw-r--r-- | ipaserver/plugins/certprofile.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ipaserver/plugins/certprofile.py b/ipaserver/plugins/certprofile.py index f44660774..2bd3311e3 100644 --- a/ipaserver/plugins/certprofile.py +++ b/ipaserver/plugins/certprofile.py @@ -310,6 +310,11 @@ class certprofile_mod(LDAPUpdate): raise errors.ProtectedEntryError(label='certprofile', key=keys[0], reason=_('Certificate profiles cannot be renamed')) if 'file' in options: + # ensure operator has permission to update a certprofile + if not ldap.can_write(dn, 'ipacertprofilestoreissued'): + raise errors.ACIError(info=_( + "Insufficient privilege to modify a certificate profile.")) + with self.api.Backend.ra_certprofile as profile_api: profile_api.disable_profile(keys[0]) try: |