diff options
| author | Martin Basti <mbasti@redhat.com> | 2016-09-20 13:00:53 +0200 |
|---|---|---|
| committer | Martin Babinsky <mbabinsk@redhat.com> | 2016-09-20 17:35:28 +0200 |
| commit | 8f8e3d008f1de91337a83ea6d271662432209767 (patch) | |
| tree | 05de56d6849ba5eebbecd6702cc81487922f21da /ipaserver/plugins/idviews.py | |
| parent | 37200806118d39ef8afe84ad5887a294d54e2659 (diff) | |
| download | freeipa-8f8e3d008f1de91337a83ea6d271662432209767.tar.gz freeipa-8f8e3d008f1de91337a83ea6d271662432209767.tar.xz freeipa-8f8e3d008f1de91337a83ea6d271662432209767.zip | |
Use constant for user and group patterns
User and groups regexp are the same and constant should be used to avoid
any future misconfigurations.
https://fedorahosted.org/freeipa/ticket/5822
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
Reviewed-By: Alexander Bokovoy <abokovoy@redhat.com>
Diffstat (limited to 'ipaserver/plugins/idviews.py')
| -rw-r--r-- | ipaserver/plugins/idviews.py | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/ipaserver/plugins/idviews.py b/ipaserver/plugins/idviews.py index 371e09211..1d7cba246 100644 --- a/ipaserver/plugins/idviews.py +++ b/ipaserver/plugins/idviews.py @@ -29,7 +29,11 @@ from .baseldap import (LDAPQuery, LDAPObject, LDAPCreate, from .hostgroup import get_complete_hostgroup_member_list from .service import validate_certificate from ipalib import api, Str, Int, Bytes, Flag, _, ngettext, errors, output -from ipalib.constants import IPA_ANCHOR_PREFIX, SID_ANCHOR_PREFIX +from ipalib.constants import ( + IPA_ANCHOR_PREFIX, + SID_ANCHOR_PREFIX, + PATTERN_GROUPUSER_NAME, +) from ipalib.plugable import Registry from ipalib.util import (normalize_sshpubkey, validate_sshpubkey, convert_sshpubkey_post) @@ -841,7 +845,7 @@ class idoverrideuser(baseidoverride): takes_params = baseidoverride.takes_params + ( Str('uid?', - pattern='^[a-zA-Z0-9_.][a-zA-Z0-9_.-]*[a-zA-Z0-9_.$-]?$', + pattern=PATTERN_GROUPUSER_NAME, pattern_errmsg='may only include letters, numbers, _, -, . and $', maxlength=255, cli_name='login', @@ -944,7 +948,7 @@ class idoverridegroup(baseidoverride): takes_params = baseidoverride.takes_params + ( Str('cn?', - pattern='^[a-zA-Z0-9_.][a-zA-Z0-9_.-]*[a-zA-Z0-9_.$-]?$', + pattern=PATTERN_GROUPUSER_NAME, pattern_errmsg='may only include letters, numbers, _, -, . and $', maxlength=255, cli_name='group_name', |