diff options
| author | Martin Basti <mbasti@redhat.com> | 2016-09-22 14:39:16 +0200 |
|---|---|---|
| committer | Martin Basti <mbasti@redhat.com> | 2016-09-23 09:23:41 +0200 |
| commit | 9b68d2a1f858854bc3cf2d6024f3fd3d79c2f696 (patch) | |
| tree | 05b54fce4f950dc16051e2bf081f33698cd2a203 /ipaserver/install | |
| parent | 4d7d53c9664c9e68d7c6cda1a65cae7551423df7 (diff) | |
| download | freeipa-9b68d2a1f858854bc3cf2d6024f3fd3d79c2f696.tar.gz freeipa-9b68d2a1f858854bc3cf2d6024f3fd3d79c2f696.tar.xz freeipa-9b68d2a1f858854bc3cf2d6024f3fd3d79c2f696.zip | |
Pylint: enable global-variable-not-assigned check
the global keyword should be used only when variable from outside is
assigned inside, otherwise it has no effect and just confuses developers
Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
Diffstat (limited to 'ipaserver/install')
| -rw-r--r-- | ipaserver/install/dns.py | 3 | ||||
| -rw-r--r-- | ipaserver/install/sysupgrade.py | 3 |
2 files changed, 0 insertions, 6 deletions
diff --git a/ipaserver/install/dns.py b/ipaserver/install/dns.py index dedafec28..912b94fb7 100644 --- a/ipaserver/install/dns.py +++ b/ipaserver/install/dns.py @@ -314,9 +314,6 @@ def install_check(standalone, api, replica, options, hostname): def install(standalone, replica, options, api=api): - global ip_addresses - global reverse_zones - local_dnskeysyncd_dn = DN(('cn', 'DNSKeySync'), ('cn', api.env.host), ('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), api.env.basedn) diff --git a/ipaserver/install/sysupgrade.py b/ipaserver/install/sysupgrade.py index 1eba38cd0..e9192ac2f 100644 --- a/ipaserver/install/sysupgrade.py +++ b/ipaserver/install/sysupgrade.py @@ -35,17 +35,14 @@ def _load_sstore(): def get_upgrade_state(module, state): _load_sstore() - global _sstore return _sstore.get_state(module, state) def set_upgrade_state(module, state, value): _load_sstore() - global _sstore _sstore.backup_state(module, state, value) def remove_upgrade_state(module, state): _load_sstore() - global _sstore _sstore.delete_state(module, state) def remove_upgrade_file(): |