summaryrefslogtreecommitdiffstats
path: root/ipaserver/install/plugins
diff options
context:
space:
mode:
authorMartin Basti <mbasti@redhat.com>2016-01-06 20:26:09 +0100
committerMartin Basti <mbasti@redhat.com>2016-01-07 16:36:22 +0100
commit8f09499ee02d4bb3ae924a7606ed38458cc1b5b4 (patch)
treea32dec947a893fe00fb29732725e3cc5d8ff2112 /ipaserver/install/plugins
parentae2462738b47c0f00133ae377854b31ddcb912a2 (diff)
downloadfreeipa-8f09499ee02d4bb3ae924a7606ed38458cc1b5b4.tar.gz
freeipa-8f09499ee02d4bb3ae924a7606ed38458cc1b5b4.tar.xz
freeipa-8f09499ee02d4bb3ae924a7606ed38458cc1b5b4.zip
update_uniqueness plugin: fix referenced before assigment error
This error may potentially happen when plugin migration is skipped due an error. In that case variable 'update' was undefined. Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
Diffstat (limited to 'ipaserver/install/plugins')
-rw-r--r--ipaserver/install/plugins/update_uniqueness.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/ipaserver/install/plugins/update_uniqueness.py b/ipaserver/install/plugins/update_uniqueness.py
index b4c0c81a0..ea1c6753c 100644
--- a/ipaserver/install/plugins/update_uniqueness.py
+++ b/ipaserver/install/plugins/update_uniqueness.py
@@ -214,8 +214,8 @@ class update_uniqueness_plugins_to_new_syntax(Updater):
root_logger.error("Unable to migrate configuration of "
"plugin %s (%s)",
entry.dn, e)
-
- update_list.append(update)
+ else:
+ update_list.append(update)
return False, update_list