diff options
| author | Jan Cholasta <jcholast@redhat.com> | 2016-11-22 15:24:31 +0100 |
|---|---|---|
| committer | Martin Basti <mbasti@redhat.com> | 2016-11-29 14:50:51 +0100 |
| commit | 7b966e8577fdb56f069cf26a6ab4d6c77b8743b9 (patch) | |
| tree | 8154776f6cfeae37e576e21e5dcdc52958d1a771 /ipapython | |
| parent | d6b755e3fcaf32158f4ee36d45e3344b4a03fbc2 (diff) | |
| download | freeipa-7b966e8577fdb56f069cf26a6ab4d6c77b8743b9.tar.gz freeipa-7b966e8577fdb56f069cf26a6ab4d6c77b8743b9.tar.xz freeipa-7b966e8577fdb56f069cf26a6ab4d6c77b8743b9.zip | |
ipautil: remove get_domain_name()
get_domain_name() and related code depends on ipaplatform.
Replace all uses of get_domain_name() with api.env.domain and remove
get_domain_name() and all of the related code.
https://fedorahosted.org/freeipa/ticket/6474
Reviewed-By: Stanislav Laznicka <slaznick@redhat.com>
Diffstat (limited to 'ipapython')
| -rw-r--r-- | ipapython/config.py | 144 | ||||
| -rw-r--r-- | ipapython/ipautil.py | 11 |
2 files changed, 0 insertions, 155 deletions
diff --git a/ipapython/config.py b/ipapython/config.py index f71c696f9..5f1295c40 100644 --- a/ipapython/config.py +++ b/ipapython/config.py @@ -23,29 +23,8 @@ from optparse import ( # pylint: enable=deprecated-module from copy import copy -from dns import resolver, rdatatype -from dns.exception import DNSException -# pylint: disable=import-error -from six.moves.configparser import SafeConfigParser -from six.moves.urllib.parse import urlsplit -# pylint: enable=import-error - from ipapython.dn import DN -from ipaplatform.paths import paths -import dns.name - -import socket - - -class IPAConfigError(Exception): - def __init__(self, msg=''): - self.msg = msg - Exception.__init__(self, msg) - def __repr__(self): - return self.msg - - __str__ = __repr__ class IPAFormatter(IndentedHelpFormatter): """Our own optparse formatter that indents multiple lined usage string.""" @@ -132,131 +111,8 @@ def verify_args(parser, args, needed_args = None): parser.error("no %s specified" % needed_list[len_have]) -class IPAConfig(object): - def __init__(self): - self.default_realm = None - self.default_server = [] - self.default_domain = None - - def get_realm(self): - if self.default_realm: - return self.default_realm - else: - raise IPAConfigError("no default realm") - - def get_server(self): - if len(self.default_server): - return self.default_server - else: - raise IPAConfigError("no default server") - - def get_domain(self): - if self.default_domain: - return self.default_domain - else: - raise IPAConfigError("no default domain") - -# Global library config -config = IPAConfig() - -def __parse_config(discover_server = True): - p = SafeConfigParser() - p.read(paths.IPA_DEFAULT_CONF) - - try: - if not config.default_realm: - config.default_realm = p.get("global", "realm") - except Exception: - pass - if discover_server: - try: - s = p.get("global", "xmlrpc_uri") - server = urlsplit(s) - config.default_server.append(server.netloc) - except Exception: - pass - try: - if not config.default_domain: - config.default_domain = p.get("global", "domain") - except Exception: - pass - -def __discover_config(discover_server = True): - servers = [] - try: - if not config.default_domain: - # try once with REALM -> domain - domain = str(config.default_realm).lower() - name = "_ldap._tcp." + domain - - try: - servers = resolver.query(name, rdatatype.SRV) - except DNSException: - # try cycling on domain components of FQDN - try: - domain = dns.name.from_text(socket.getfqdn()) - except DNSException: - return False - - while True: - domain = domain.parent() - - if str(domain) == '.': - return False - name = "_ldap._tcp.%s" % domain - try: - servers = resolver.query(name, rdatatype.SRV) - break - except DNSException: - pass - - config.default_domain = str(domain).rstrip(".") - - if discover_server: - if not servers: - name = "_ldap._tcp.%s." % config.default_domain - try: - servers = resolver.query(name, rdatatype.SRV) - except DNSException: - pass - - for server in servers: - hostname = str(server.target).rstrip(".") - config.default_server.append(hostname) - - except Exception: - pass - def add_standard_options(parser): parser.add_option("--realm", dest="realm", help="Override default IPA realm") parser.add_option("--server", dest="server", help="Override default FQDN of IPA server") parser.add_option("--domain", dest="domain", help="Override default IPA DNS domain") - -def init_config(options=None): - if options: - config.default_realm = options.realm - config.default_domain = options.domain - if options.server: - config.default_server.extend(options.server.split(",")) - - if len(config.default_server): - discover_server = False - else: - discover_server = True - __parse_config(discover_server) - __discover_config(discover_server) - - # make sure the server list only contains unique items - new_server = [] - for server in config.default_server: - if server not in new_server: - new_server.append(server) - config.default_server = new_server - - if not config.default_realm: - raise IPAConfigError("IPA realm not found in DNS, in the config file (/etc/ipa/default.conf) or on the command line.") - if not config.default_server: - raise IPAConfigError("IPA server not found in DNS, in the config file (/etc/ipa/default.conf) or on the command line.") - if not config.default_domain: - raise IPAConfigError("IPA domain not found in the config file (/etc/ipa/default.conf) or on the command line.") diff --git a/ipapython/ipautil.py b/ipapython/ipautil.py index e613fd4d4..762cd914d 100644 --- a/ipapython/ipautil.py +++ b/ipapython/ipautil.py @@ -50,7 +50,6 @@ from six.moves import input from six.moves import urllib from ipapython.ipa_log_manager import root_logger -from ipapython import config from ipaplatform.paths import paths from ipapython.dn import DN @@ -63,16 +62,6 @@ KRB5KDC_ERR_SVC_UNAVAILABLE = 2529638941 # A service is not available that is # required to process the request -def get_domain_name(): - try: - config.init_config() - domain_name = config.config.get_domain() - except Exception: - return None - - return domain_name - - class UnsafeIPAddress(netaddr.IPAddress): """Any valid IP address with or without netmask.""" |
