summaryrefslogtreecommitdiffstats
path: root/install
diff options
context:
space:
mode:
authorMartin Kosek <mkosek@redhat.com>2013-07-26 10:58:52 +0200
committerMartin Kosek <mkosek@redhat.com>2013-07-26 12:51:10 +0200
commit6a0aabede5875ad23dab777d0c2f6bac05fa2599 (patch)
tree9910c39430ab1c922e0d96d1f341f28af5b6a08a /install
parent8a41b64a8c2f77d5d1245884cb7ef3d0a2e81f93 (diff)
downloadfreeipa-6a0aabede5875ad23dab777d0c2f6bac05fa2599.tar.gz
freeipa-6a0aabede5875ad23dab777d0c2f6bac05fa2599.tar.xz
freeipa-6a0aabede5875ad23dab777d0c2f6bac05fa2599.zip
Free NSS objects in --external-ca scenario
In external CA installation, ipa-server-install leaked NSS objects which caused an installation crash later when a subsequent call of NSSConnection tried to free them. Properly freeing the NSS objects avoid this crash. https://fedorahosted.org/freeipa/ticket/3773
Diffstat (limited to 'install')
-rwxr-xr-xinstall/tools/ipa-server-install5
1 files changed, 5 insertions, 0 deletions
diff --git a/install/tools/ipa-server-install b/install/tools/ipa-server-install
index 672369c54..fafa14ea1 100755
--- a/install/tools/ipa-server-install
+++ b/install/tools/ipa-server-install
@@ -698,18 +698,23 @@ def main():
sys.exit(1)
certdict = dict((DN(str(cert.subject)), cert) for cert in extchain)
+ del extchain
certissuer = DN(str(extcert.issuer))
if certissuer not in certdict:
print "The external certificate is not signed by the external CA (unknown issuer %s)." % certissuer
sys.exit(1)
cert = extcert
+ del extcert
while cert.issuer != cert.subject:
certissuer = DN(str(cert.issuer))
if certissuer not in certdict:
print "The external CA chain is incomplete (%s is missing from the chain)." % certissuer
sys.exit(1)
+ del cert
cert = certdict[certissuer]
+ del certdict
+ del cert
# We only set up the CA if the PKCS#12 options are not given.
if options.dirsrv_pkcs12: