diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2012-07-19 14:47:48 +0200 |
|---|---|---|
| committer | Petr Vobornik <pvoborni@redhat.com> | 2012-07-25 11:05:56 +0200 |
| commit | 65bd82eaa1a0d8e377b58ebc6b5d96ea9364c993 (patch) | |
| tree | 8d6495127926a6927bf1aef10f557a70ee3e87f6 /install/ui/add.js | |
| parent | dedb180ddc773baf42bb31efc07a1dda698631bb (diff) | |
| download | freeipa-65bd82eaa1a0d8e377b58ebc6b5d96ea9364c993.tar.gz freeipa-65bd82eaa1a0d8e377b58ebc6b5d96ea9364c993.tar.xz freeipa-65bd82eaa1a0d8e377b58ebc6b5d96ea9364c993.zip | |
IDs and names for dialogs
It's hard to detect if or which type dialog is displayed becouse not all dialogs have IDs.
On dialog open, it's id or name (if id is not set) is used for containing element id. Many of dialog types were missing id or name so name was added to each dialog type.
In HTML, element's id should be unique. Our framework allows opening two dialogs with the same id. It may lead to state where getElementById method may have unpredicted behaviour. Therefore attribute 'data-name' with dialog's name was added to dialog's containing element. Automation framework can search more reliable by using this attribute instead of id.
https://fedorahosted.org/freeipa/ticket/2853
Diffstat (limited to 'install/ui/add.js')
| -rw-r--r-- | install/ui/add.js | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/install/ui/add.js b/install/ui/add.js index eafcd0d57..4ca0f0418 100644 --- a/install/ui/add.js +++ b/install/ui/add.js @@ -27,6 +27,8 @@ IPA.entity_adder_dialog = function(spec) { spec = spec || {}; + spec.name = spec.name || 'entity_adder_dialog'; + var that = IPA.dialog(spec); that.method = spec.method || 'add'; |