diff options
| author | Petr Vobornik <pvoborni@redhat.com> | 2013-08-29 15:19:02 +0200 |
|---|---|---|
| committer | Petr Vobornik <pvoborni@redhat.com> | 2013-10-16 18:06:30 +0200 |
| commit | b4fc6f4ba880c210cf1a439036db4695cc74c5ae (patch) | |
| tree | 1b01c56dcbfd5e9742d56c03dd851e2b12f4d38c /install/html | |
| parent | c49cf9572addb2e773108e4530e023385f8c2180 (diff) | |
| download | freeipa-b4fc6f4ba880c210cf1a439036db4695cc74c5ae.tar.gz freeipa-b4fc6f4ba880c210cf1a439036db4695cc74c5ae.tar.xz freeipa-b4fc6f4ba880c210cf1a439036db4695cc74c5ae.zip | |
Load updated Web UI files after server upgrade
Issue:
* There was no caching policy specified.
* -> Browsers use their own default policy.
* -> After upgrade, some Web UI files might have been actualized some not.
* -> With schema change may result into weird bugs in Web UI
Solution considerations:
1. Detect server version change and hard-reload at runtime
Detection is easy. Problem is the reload. Obvious candidate 'window.location.reload(true)' works in Firefox but not in Chrome because expected behavior when parameter is used is not in standard and therefore Chromium/WebKit authors did not implement it.
2. Application Cache
HTML 5 technology which lets web apps to run offline. Besides weird issues with event handlers which I encountered, this would be an ideal candidate. Simple change of manifest file would lead to reload of all files (requires reload of page to used the new files).
Showstopper was usage with untrusted certificate. If user did not add exception for the cert or its CA and would visit the page for a second time, all AJAX calls would fail.
3. Set Expires to now() for everything
Web UI rarely changes so this is an overkill. Setting it to different value is not a solution either. We can't predict when the upgrade will happen and when new Web UI will be needed.
Solution:
* Implemented a mini loader which loads basic resources. Dojo loader takes action after Dojo is loaded.
* The loader adds a version parameter (?v=__NUM_VERSION__) to all requests.
* Version is defined in the loader. It's set to current in `make version-update`.
* All static pages use this loader to fetch their resources.
* Version is also passed to dojo loader as cache-bust for the same effect.
* Expire header was set to 'access time plus 1 year' for /ui folder. Exceptions are HTML files and loader (set to immediate expiration).
Possible issues:
* Images are cached but not requested with version param.
* Images with version and without are considered different
* -> We would have to attach version to all URIs - in CSS and in JS. But we should avoid changing jQuery UI CSS.
* Proposed solution is to change image name when changing image. Image change is done rarely.
* Version is set by build and therefore updated just on server update. It might cause trouble with different update schedule of plugins.
* No action taken to address this issue yet.
* We might leave it on plugin devs (own .conf in /etc/httpd/conf.d/)
* or set expires to now for all plugins
* running `make version-update` is required in order to use static version of UI for testing
https://fedorahosted.org/freeipa/ticket/3798
Diffstat (limited to 'install/html')
| -rw-r--r-- | install/html/browserconfig.html | 29 | ||||
| -rw-r--r-- | install/html/ssbrowser.html | 49 | ||||
| -rw-r--r-- | install/html/unauthorized.html | 16 |
3 files changed, 59 insertions, 35 deletions
diff --git a/install/html/browserconfig.html b/install/html/browserconfig.html index a7784f75b..d867a1941 100644 --- a/install/html/browserconfig.html +++ b/install/html/browserconfig.html @@ -3,16 +3,25 @@ <head> <meta charset="utf-8"> <title>IPA: Identity Policy Audit</title> - - <link rel="stylesheet" type="text/css" href="../ui/jquery-ui.css" /> - <link rel="stylesheet" type="text/css" href="../ui/ipa.css" /> - <link rel="stylesheet" type="text/css" href="ipa_error.css" /> - - <script type="text/javascript" src="../ui/js/libs/jquery.js"></script> - <script type="text/javascript" src="../ui/js/libs/jquery-ui.js"></script> - <script type="text/javascript" src="krb.js"></script> - <script type="text/javascript" src="ffconfig.js"></script> - <script type="text/javascript" src="ffconfig_page.js"></script> + <script type="text/javascript" src="../ui/js/libs/loader.js"></script> + <script type="text/javascript"> + (function() { + var styles = [ + '../ui/jquery-ui.css', + '../ui/ipa.css', + 'ipa_error.css' + ]; + var scripts = [ + '../ui/js/libs/jquery.js', + '../ui/js/libs/jquery-ui.js', + 'krb.js', + 'ffconfig.js', + 'ffconfig_page.js' + ]; + ipa_loader.scripts(scripts); + ipa_loader.styles(styles); + })(); + </script> </head> <body class="info-page"> diff --git a/install/html/ssbrowser.html b/install/html/ssbrowser.html index 72fd573cf..896cabcec 100644 --- a/install/html/ssbrowser.html +++ b/install/html/ssbrowser.html @@ -3,30 +3,41 @@ <head> <meta charset="utf-8"> <title>IPA: Identity Policy Audit</title> - - <link rel="stylesheet" type="text/css" href="../ui/jquery-ui.css" /> - <link rel="stylesheet" type="text/css" href="../ui/ipa.css" /> - <link rel="stylesheet" type="text/css" href="ipa_error.css" /> - - <script type="text/javascript" src="../ui/js/libs/jquery.js"></script> - <script type="text/javascript" src="krb.js"></script> + <script type="text/javascript" src="../ui/js/libs/loader.js"></script> <script type="text/javascript"> - $(document).ready(function() { - var domain = '.' + (IPA_DOMAIN || 'example.com'); - $('.example-domain').text(domain); + (function() { + function loaded() { + $(document).ready(function() { + var domain = '.' + (IPA_DOMAIN || 'example.com'); + $('.example-domain').text(domain); - if ($.browser.mozilla) { - var ff_config = $("#configurefirefox"); - var obj = $('<object/>', { - type: 'text/html', - 'class': 'browser-config' + if ($.browser.mozilla) { + var ff_config = $("#configurefirefox"); + var obj = $('<object/>', { + type: 'text/html', + 'class': 'browser-config' + }); + obj.prop('data', 'jar:/ipa/errors/configure.jar!/preferences.html'); + obj.appendTo(ff_config); + ff_config.show(); + } }); - obj.prop('data', 'jar:/ipa/errors/configure.jar!/preferences.html'); - obj.appendTo(ff_config); - ff_config.show(); } - }); + + var styles = [ + '../ui/jquery-ui.css', + '../ui/ipa.css', + 'ipa_error.css' + ]; + var scripts = [ + '../ui/js/libs/jquery.js', + 'krb.js' + ]; + ipa_loader.scripts(scripts, loaded); + ipa_loader.styles(styles); + })(); </script> + </head> <body class="info-page"> diff --git a/install/html/unauthorized.html b/install/html/unauthorized.html index 0fac88b98..5c5ed7e98 100644 --- a/install/html/unauthorized.html +++ b/install/html/unauthorized.html @@ -3,12 +3,16 @@ <head> <meta charset="utf-8"> <title>IPA: Identity Policy Audit</title> - - <script type="text/javascript" src="../ui/js/libs/jquery.js"></script> - - <link rel="stylesheet" type="text/css" href="../ui/jquery-ui.css" /> - <link rel="stylesheet" type="text/css" href="../ui/ipa.css" /> - <link rel="stylesheet" type="text/css" href="ipa_error.css" /> + <script type="text/javascript" src="../ui/js/libs/loader.js"></script> + <script type="text/javascript"> + (function() { + var styles = [ + '../ui/ipa.css', + 'ipa_error.css' + ]; + ipa_loader.styles(styles); + })(); + </script> </head> <body class="info-page"> |