spec file: clean up BuildRequires

Add missing cyrus-sasl-devel, python-cffi, python-custodia,
python-dateutil, python-nose, python-paste, python-sss-murmur,
python-sssdconfig and systemd-python BuildRequires.

Remove unused custodia, java-headless, m4, policycoreutils,
python-kdcproxy, python-rhsm, pyOpenSSL and systemd-units BuildRequires.

Correct versioned BuildRequires and provide explanatory comments.

https://fedorahosted.org/freeipa/ticket/6418

Reviewed-By: Petr Spacek <pspacek@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>

1 files changed, 77 insertions, 50 deletions

diff --git a/freeipa.spec.in b/freeipa.spec.in
index 423884ff5..2dfe9da57 100644
--- a/freeipa.spec.in
+++ b/freeipa.spec.in
@@ -38,82 +38,109 @@ URL:            http://www.freeipa.org/
 Source0:        freeipa-%{version}.tar.gz
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
-%if ! %{ONLY_CLIENT}
-BuildRequires:  389-ds-base-devel >= 1.3.5.6
-BuildRequires:  svrcore-devel
-BuildRequires:  policycoreutils >= 2.1.12-5
-BuildRequires:  systemd-units
-BuildRequires:  samba-devel >= %{samba_version}
-BuildRequires:  samba-python
-BuildRequires:  libtalloc-devel
-BuildRequires:  libtevent-devel
-%endif # ONLY_CLIENT
-BuildRequires:  nspr-devel
-BuildRequires:  nss-devel
-BuildRequires:  openssl-devel
 BuildRequires:  openldap-devel
-BuildRequires:  krb5-devel >= 1.13
-BuildRequires:  krb5-workstation
-BuildRequires:  libuuid-devel
-BuildRequires:  libcurl-devel >= 7.21.7-2
+# 1.12: libkrad (http://krbdev.mit.edu/rt/Ticket/Display.html?id=7678)
+BuildRequires:  krb5-devel >= 1.12
+BuildRequires:  libcurl-devel
+# 1.27.4: xmlrpc_curl_xportparms.gssapi_delegation
 BuildRequires:  xmlrpc-c-devel >= 1.27.4
 BuildRequires:  popt-devel
 BuildRequires:  autoconf
 BuildRequires:  automake
-BuildRequires:  m4
 BuildRequires:  libtool
 BuildRequires:  gettext
 BuildRequires:  python-devel
+%if 0%{?with_python3}
+BuildRequires:  python3-devel
+%endif # with_python3
+# %{_unitdir}, %{_tmpfilesdir}
+BuildRequires:  systemd
+BuildRequires:  libini_config-devel
+BuildRequires:  cyrus-sasl-devel
+%if ! %{ONLY_CLIENT}
+# 1.3.3.9: DS_Sleep (https://fedorahosted.org/389/ticket/48005)
+BuildRequires:  389-ds-base-devel >= 1.3.3.9
+BuildRequires:  svrcore-devel
+%if 0%{?rhel}
+BuildRequires:  samba-devel >= 4.0.0
+%else
+BuildRequires:  samba-devel >= 2:4.0.0
+%endif
+BuildRequires:  libtalloc-devel
+BuildRequires:  libtevent-devel
+BuildRequires:  nspr-devel
+BuildRequires:  nss-devel
+BuildRequires:  openssl-devel
+BuildRequires:  libuuid-devel
 BuildRequires:  python-ldap
-BuildRequires:  python-setuptools
-BuildRequires:  python-nss
-BuildRequires:  python-cryptography >= 0.9
 BuildRequires:  python-netaddr
-BuildRequires:  python-gssapi >= 1.1.2
-BuildRequires:  python-rhsm
-BuildRequires:  pyOpenSSL
-BuildRequires:  pylint >= 1.0
-# workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506
-BuildRequires:  python2-polib
-BuildRequires:  python-libipa_hbac
-BuildRequires:  python-memcached
-BuildRequires:  python-lxml
-BuildRequires:  python-pyasn1 >= 0.0.9a
-BuildRequires:  python-qrcode-core >= 5.0.0
-BuildRequires:  python-dns >= 1.11.1
+BuildRequires:  python-gssapi
+BuildRequires:  python-dns
 BuildRequires:  libsss_idmap-devel
+# 1.14.0: sss_nss_getnamebycert (https://fedorahosted.org/sssd/ticket/2897)
 BuildRequires:  libsss_nss_idmap-devel >= 1.14.0
-BuildRequires:  java-headless
-BuildRequires:  jsl
 BuildRequires:  rhino
 BuildRequires:  libverto-devel
-BuildRequires:  systemd
 BuildRequires:  libunistring-devel
 BuildRequires:  python-lesscpy
-BuildRequires:  python-yubico >= 1.2.3
-BuildRequires:  openssl-devel
-BuildRequires:  pki-base >= 10.3.3-3
-BuildRequires:  python-pytest-multihost >= 0.5
-BuildRequires:  python-pytest-sourceorder
-BuildRequires:  python-kdcproxy >= 0.3
 BuildRequires:  python-six
-BuildRequires:  python-jwcrypto
-BuildRequires:  custodia
-BuildRequires:  libini_config-devel >= 1.2.0
+BuildRequires:  python-netifaces
+%endif # ONLY_CLIENT
+
+#
+# Build dependencies for makeapi/makeaci
+#
+BuildRequires:  krb5-workstation
+BuildRequires:  python-setuptools
+BuildRequires:  python-nss
+# 0.6: serialization.load_pem_private_key, load_pem_public_key
+BuildRequires:  python-cryptography >= 0.6
+BuildRequires:  python-libipa_hbac
+BuildRequires:  python-memcached
+BuildRequires:  python-lxml
+BuildRequires:  python-pyasn1
+# pki Python package
+BuildRequires:  pki-base
 BuildRequires:  dbus-python
-BuildRequires:  python-netifaces >= 0.10.4
 BuildRequires:  python-libsss_nss_idmap
+BuildRequires:  python-cffi
+
+#
+# Build dependencies for lint
+#
+BuildRequires:  samba-python
+BuildRequires:  pylint >= 1.0
+# workaround for https://bugzilla.redhat.com/show_bug.cgi?id=1096506
+BuildRequires:  python2-polib
+# 5.0.0: QRCode.print_ascii
+BuildRequires:  python-qrcode-core >= 5.0.0
+# 1.11.0: resolver.YXDOMAIN, Resolver.set_flags
+BuildRequires:  python-dns >= 1.11.0
+BuildRequires:  jsl
+BuildRequires:  python-yubico
+# 10.2.1: crypto.NSSCryptoProvider(password_file)
+BuildRequires:  pki-base >= 10.2.1
+BuildRequires:  python-pytest-multihost
+BuildRequires:  python-pytest-sourceorder
+BuildRequires:  python-jwcrypto
+BuildRequires:  python-custodia
+BuildRequires:  python-dateutil
 BuildRequires:  python-sss
+BuildRequires:  python-sss-murmur
+BuildRequires:  python-sssdconfig
+BuildRequires:  python-nose
+BuildRequires:  python-paste
+BuildRequires:  systemd-python
 
+#
 # Build dependencies for unit tests
+#
+%if ! %{ONLY_CLIENT}
 BuildRequires:  libcmocka-devel
 BuildRequires:  nss_wrapper
 # Required by ipa_kdb_tests
 BuildRequires:  %{_libdir}/krb5/plugins/kdb/db2.so
-
-%if 0%{?with_python3}
-BuildRequires:  python3-devel
-%endif  # with_python3
+%endif # ONLY_CLIENT
 
 %description
 IPA is an integrated solution to provide centrally managed Identity (users,