summaryrefslogtreecommitdiffstats
path: root/daemons
diff options
context:
space:
mode:
authorMartin Kosek <mkosek@redhat.com>2013-02-12 16:35:51 +0100
committerMartin Kosek <mkosek@redhat.com>2013-02-14 10:09:52 +0100
commitdfad4396ffa9d47dc9effb832f05f1b9f7c36582 (patch)
treeea26fff775ea55eea14b885ca8d7ab8e5a18bc44 /daemons
parent93ea8a6ac311d7365b093b3449b281bbfa0911ab (diff)
downloadfreeipa-dfad4396ffa9d47dc9effb832f05f1b9f7c36582.tar.gz
freeipa-dfad4396ffa9d47dc9effb832f05f1b9f7c36582.tar.xz
freeipa-dfad4396ffa9d47dc9effb832f05f1b9f7c36582.zip
ipa-kdb: fix retry logic in ipadb_deref_search
This function retried an LDAP search when the result was OK due to flawed logic of retry detection (ipadb_need_retry function which returns true when we need retry and not 0). https://fedorahosted.org/freeipa/ticket/3413
Diffstat (limited to 'daemons')
-rw-r--r--daemons/ipa-kdb/ipa_kdb_common.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/daemons/ipa-kdb/ipa_kdb_common.c b/daemons/ipa-kdb/ipa_kdb_common.c
index 121b8096d..e227602ea 100644
--- a/daemons/ipa-kdb/ipa_kdb_common.c
+++ b/daemons/ipa-kdb/ipa_kdb_common.c
@@ -325,7 +325,7 @@ krb5_error_code ipadb_deref_search(struct ipadb_context *ipactx,
ctrl, NULL,
&std_timeout, LDAP_NO_LIMIT,
res);
- retry = !ipadb_need_retry(ipactx, ret) && times > 0;
+ retry = ipadb_need_retry(ipactx, ret) && times > 0;
if (retry) {
/* Free result before next try */