summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2017-01-11 17:08:30 +0100
committerMartin Babinsky <mbabinsk@redhat.com>2017-01-18 09:05:56 +0100
commit5c18feaa206bbaee692fc3640b7b79c8d9d6a638 (patch)
tree35a1254313917ad5f7ab527b33dc1e103f44fa7e
parent6d52c0fe6acb09f3b8525840dfacc3f0885eac37 (diff)
downloadfreeipa-5c18feaa206bbaee692fc3640b7b79c8d9d6a638.tar.gz
freeipa-5c18feaa206bbaee692fc3640b7b79c8d9d6a638.tar.xz
freeipa-5c18feaa206bbaee692fc3640b7b79c8d9d6a638.zip
CONFIGURE: Fix detection of pylint
If configure script was executed with --enable-pylint then it behaved the same as --disable-pylint. It does not make any sense. Resolves: https://fedorahosted.org/freeipa/ticket/6604 Reviewed-By: Christian Heimes <cheimes@redhat.com> Reviewed-By: Tomas Krizek <tkrizek@redhat.com>
-rw-r--r--configure.ac20
1 files changed, 11 insertions, 9 deletions
diff --git a/configure.ac b/configure.ac
index e8a4701c1..c84c1bc37 100644
--- a/configure.ac
+++ b/configure.ac
@@ -446,16 +446,18 @@ AM_CONDITIONAL([WITH_POLINT], [test "x${enable_i18ntests}" == "xyes"])
AC_ARG_ENABLE([pylint],
AS_HELP_STRING([--disable-pylint],
[skip Pylint in make lint target]),
- [PYLINT=no],
- [PYLINT=yes
- AC_MSG_CHECKING([for Pylint])
- $PYTHON -m pylint --version > /dev/null
- if test "$?" != "0"; then
- AC_MSG_ERROR([cannot find pylint for $PYTHON])
- fi
- AC_MSG_RESULT([yes])
- ]
+ [PYLINT=$enableval],
+ [PYLINT=yes]
)
+if test x$PYLINT != xno; then
+ AC_MSG_CHECKING([for Pylint])
+ $PYTHON -m pylint --version > /dev/null
+ if test "$?" != "0"; then
+ AC_MSG_ERROR([cannot find pylint for $PYTHON])
+ else
+ AC_MSG_RESULT([yes])
+ fi
+fi
AC_SUBST([PYLINT])
AM_CONDITIONAL([WITH_PYLINT], [test "x${PYLINT}" != "xno"])