Extract method to map principal to princpal type

Part of: https://pagure.io/freeipa/issue/5011

Reviewed-By: Tomas Krizek <tkrizek@redhat.com>

1 files changed, 14 insertions, 15 deletions

diff --git a/ipaserver/plugins/cert.py b/ipaserver/plugins/cert.py
index 46518d9bd..b53caf493 100644
--- a/ipaserver/plugins/cert.py
+++ b/ipaserver/plugins/cert.py
@@ -558,29 +558,17 @@ class cert_request(Create, BaseCertMethod, VirtualCommand):
 
         principal = kw.get('principal')
         principal_string = unicode(principal)
+        principal_type = principal_to_principal_type(principal)
 
-        if principal.is_user:
-            principal_type = USER
-        elif principal.is_host:
-            principal_type = HOST
-        elif principal.service_name == 'krbtgt':
-            principal_type = KRBTGT
+        if principal_type == KRBTGT:
             if profile_id != self.Backend.ra.KDC_PROFILE:
                 raise errors.ACIError(
                     info=_("krbtgt certs can use only the %s profile") % (
                            self.Backend.ra.KDC_PROFILE))
-        else:
-            principal_type = SERVICE
 
         bind_principal = kerberos.Principal(getattr(context, 'principal'))
         bind_principal_string = unicode(bind_principal)
-
-        if bind_principal.is_user:
-            bind_principal_type = USER
-        elif bind_principal.is_host:
-            bind_principal_type = HOST
-        else:
-            bind_principal_type = SERVICE
+        bind_principal_type = principal_to_principal_type(bind_principal)
 
         if (bind_principal_string != principal_string and
                 bind_principal_type != HOST):
@@ -834,6 +822,17 @@ class cert_request(Create, BaseCertMethod, VirtualCommand):
         )
 
 
+def principal_to_principal_type(principal):
+    if principal.is_user:
+        return USER
+    elif principal.is_host:
+        return HOST
+    elif principal.service_name == 'krbtgt':
+        return KRBTGT
+    else:
+        return SERVICE
+
+
 def _dns_name_matches_principal(name, principal, principal_obj):
     """
     Ensure that a DNS name matches the given principal.