freeipa.git/util, branch fix_ber_scanf

Make sure to have storage space for tag

2019-09-16T15:18:30+00:00

ber_scanf expects a pointer to a ber_tag_t to return the tag pointed at
by "t", if that is not provided the pointer will be store in whatever
memory location is pointed by the stack at that time causeing a crash.

Note that this is effectively unused code because in ipa-kdb the only
party that can write a key_data structure to be stored is te kdb_driver
itself and we never encode these s2kparam data.

But we need to handle this for future proofing.

Fixes #8071

Signed-off-by: Simo Sorce

Log INFO message when LDAP connection fails on startup

2019-09-05T18:53:55+00:00

Since krb5_klog_syslog() always needs parameters from syslog.h, move the
include into ipa_krb5.h.

Signed-off-by: Robbie Harwood 
Reviewed-By: Christian Heimes

Compile IPA modules with C11 extensions

2019-02-07T11:33:45+00:00

- define __STDC_WANT_LIB_EXT1__ to get C11 extensions like memset_s() for
  Samba's ZERO_STRUCT() macro, see
  https://en.cppreference.com/w/c/string/byte/memset
- _DEFAULT_SOURCE enables features like htole16() from endian.h, see
  http://man7.org/linux/man-pages/man3/endian.3.html
- _POSIX_C_SOURCE >= 200809 enables features like strndup() from string.h,
  see http://man7.org/linux/man-pages/man3/strndup.3.html
- time_t is no longer implicitly defined, include time.h
- typeof() is only available as GNU extension. Use explicit types
  instead of generic __typeof__().

Fixes: https://pagure.io/freeipa/issue/7858
Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Move fips_enabled to a common library to share across different plugins

2018-08-13T12:42:16+00:00

Related: https://pagure.io/freeipa/issue/7659
Reviewed-By: Robbie Harwood

Fix $-style format string in ipa_ldap_init (util/ipa_ldap.c)

2018-07-20T16:53:38+00:00

The second argument was not used, but the first one was used twice.

Reviewed-By: Rob Crittenden

Apply sane LDAP settings to C code

2018-05-29T13:30:37+00:00

Common LDAP code from ipa-getkeytab and ipa-join are moved to libutil.a.
The common ipa_ldap_init() and ipa_tls_ssl_init() set the same options
as ldap_initialize()

Signed-off-by: Christian Heimes 
Reviewed-By: Florence Blanc-Renaud

C compilation fixes and hardening

2017-03-01T09:38:01+00:00

Fix "implicit declaration of function ‘strlen’" in ipa_pwd_ntlm.c,
credits to Lukas.

Add -Werror=implicit-function-declaration to CFLAGS to point developers
to missing includes. It causes compilation to fail when a developer
forgets to add a required include. The problem is no longer hidden in a
massive wall of text from make.

Silence a harmless error from 389-DS slapi.h until the bug is fixed in
downstream, https://pagure.io/389-ds-base/issue/48979

Signed-off-by: Christian Heimes 
Reviewed-By: Stanislav Laznicka

Add missing include of stdint.h for uint8_t

2017-02-22T14:48:36+00:00

Signed-off-by: Christian Heimes 
Reviewed-By: Simo Sorce 
Reviewed-By: Tomas Krizek

ipa_pwd: remove unnecessary dependency on dirsrv plugins

2017-02-22T14:48:36+00:00

"dirsrv/slapi-plugin.h" is unnecessary for build of ipa_pwd.
This patch allow us to move DIRSRV to daemon only dependencies

Reviewed-By: Simo Sorce 
Reviewed-By: Tomas Krizek

Build: transform util directory to libutil convenience library

2016-10-24T11:30:12+00:00

This is autoconf way of doing things. It should allow us to enable
subdir-objects automake option and stay compatible with future versions
of automake.

https://fedorahosted.org/freeipa/ticket/6418

Reviewed-By: Lukas Slebodnik 
Reviewed-By: Stanislav Laznicka 
Reviewed-By: Christian Heimes