<feed xmlns='http://www.w3.org/2005/Atom'>
<title>freeipa.git/ipatests/test_ipaserver, branch fix_ber_scanf</title>
<subtitle>FreeIPA patches</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/'/>
<entry>
<title>Fix wrong use of identity operation</title>
<updated>2019-09-04T08:30:07+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2019-09-03T11:55:27+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=0fc4b8c25cb4f1ee49cbf9b47610168b24a9ee56'/>
<id>0fc4b8c25cb4f1ee49cbf9b47610168b24a9ee56</id>
<content type='text'>
Strings should not be compared with the identity operation 'is' or
'is not'.

Fixes: https://pagure.io/freeipa/issue/8057
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;flo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Strings should not be compared with the identity operation 'is' or
'is not'.

Fixes: https://pagure.io/freeipa/issue/8057
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;flo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>move MSCSTemplate classes to ipalib</title>
<updated>2019-07-17T14:58:58+00:00</updated>
<author>
<name>Fraser Tweedale</name>
<email>ftweedal@redhat.com</email>
</author>
<published>2019-07-11T05:17:04+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=130e1dc3433977f7a80aed139d29d21c5d30d558'/>
<id>130e1dc3433977f7a80aed139d29d21c5d30d558</id>
<content type='text'>
As we expand the integration tests for external CA functionality, it
is helpful (and avoids duplication) to use the MSCSTemplate*
classes.  These currently live in ipaserver.install.cainstance, but
ipatests is no longer permitted to import from ipaserver (see commit
81714976e5e13131654c78eb734746a20237c933).  So move these classes to
ipalib.

Part of: https://pagure.io/freeipa/issue/7548

Reviewed-By: Florence Blanc-Renaud &lt;flo@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
As we expand the integration tests for external CA functionality, it
is helpful (and avoids duplication) to use the MSCSTemplate*
classes.  These currently live in ipaserver.install.cainstance, but
ipatests is no longer permitted to import from ipaserver (see commit
81714976e5e13131654c78eb734746a20237c933).  So move these classes to
ipalib.

Part of: https://pagure.io/freeipa/issue/7548

Reviewed-By: Florence Blanc-Renaud &lt;flo@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add option to remove lines from a file</title>
<updated>2019-04-02T17:35:38+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2019-04-02T13:17:52+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=3cb1ccb3b0a4f361d4d3ef667c60d5b6f4a23333'/>
<id>3cb1ccb3b0a4f361d4d3ef667c60d5b6f4a23333</id>
<content type='text'>
config_replace_variables() can now also remove lines from a file.

Related: https://pagure.io/freeipa/issue/7860
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
config_replace_variables() can now also remove lines from a file.

Related: https://pagure.io/freeipa/issue/7860
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ipatests: add test for correct modlist when value encoding differs</title>
<updated>2019-02-12T10:07:19+00:00</updated>
<author>
<name>Sergey Orlov</name>
<email>sorlov@redhat.com</email>
</author>
<published>2019-02-11T11:23:41+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=425dff1e0d2b360557075ea322309411b485d58f'/>
<id>425dff1e0d2b360557075ea322309411b485d58f</id>
<content type='text'>
See: https://pagure.io/freeipa/issue/7750
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
See: https://pagure.io/freeipa/issue/7750
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Unify and simplify LDAP service discovery</title>
<updated>2018-11-21T07:57:08+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2018-07-12T12:37:18+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=8decef33d310926c766f9b80ce78655b553a247d'/>
<id>8decef33d310926c766f9b80ce78655b553a247d</id>
<content type='text'>
Move LDAP service discovery and service definitions from
ipaserver.install to ipaserver. Simplify and unify different
implementations in favor of a single implementation.

Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Rob Crittenden &lt;rcritten@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move LDAP service discovery and service definitions from
ipaserver.install to ipaserver. Simplify and unify different
implementations in favor of a single implementation.

Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Rob Crittenden &lt;rcritten@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ipaserver.install.adtrust: fix CID 323644</title>
<updated>2018-11-07T15:37:18+00:00</updated>
<author>
<name>Alexander Bokovoy</name>
<email>abokovoy@redhat.com</email>
</author>
<published>2018-11-07T09:57:53+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=82af034023b03ae64f005c8160b9e961e7b9fd55'/>
<id>82af034023b03ae64f005c8160b9e961e7b9fd55</id>
<content type='text'>
Fix Coverity finding CID 323644: logically dead code path

The code to determine whether NetBIOS name was already set or need to be
set after deriving it from a domain or asking a user for an interactive
input, was refactored at some point to avoid retrieving the whole LDAP
entry. Instead, it was provided with the actual NetBIOS name retrieved.

As result, a part of the code got neglected and was never executed.

Fix this code and provide a test that tries to test predefined,
interactively provided and automatically derived NetBIOS name depending
on how the installer is being run.

We mock up the actual execution so that no access to LDAP or Samba is
needed.

Fixes: https://pagure.io/freeipa/issue/7753
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fix Coverity finding CID 323644: logically dead code path

The code to determine whether NetBIOS name was already set or need to be
set after deriving it from a domain or asking a user for an interactive
input, was refactored at some point to avoid retrieving the whole LDAP
entry. Instead, it was provided with the actual NetBIOS name retrieved.

As result, a part of the code got neglected and was never executed.

Fix this code and provide a test that tries to test predefined,
interactively provided and automatically derived NetBIOS name depending
on how the installer is being run.

We mock up the actual execution so that no access to LDAP or Samba is
needed.

Fixes: https://pagure.io/freeipa/issue/7753
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Py3: Replace six.moves imports</title>
<updated>2018-10-05T10:06:19+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2018-09-27T05:47:07+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=15d5e44ee89ce4c0f1f366b0d7150166f1a26844'/>
<id>15d5e44ee89ce4c0f1f366b0d7150166f1a26844</id>
<content type='text'>
Replace six.moves and six.StringIO/BytesIO imports with cannonical
Python 3 packages.

Note: six.moves.input behaves differently than builtin input function.
Therefore I left six.moves.input for now.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Fraser Tweedale &lt;ftweedal@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Replace six.moves and six.StringIO/BytesIO imports with cannonical
Python 3 packages.

Note: six.moves.input behaves differently than builtin input function.
Therefore I left six.moves.input for now.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Fraser Tweedale &lt;ftweedal@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Py3: Remove subclassing from object</title>
<updated>2018-09-27T09:49:04+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2018-09-26T09:59:50+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=b431e9b684df11c811892bd9d2a5711355f0076e'/>
<id>b431e9b684df11c811892bd9d2a5711355f0076e</id>
<content type='text'>
Python 2 had old style and new style classes. Python 3 has only new
style classes. There is no point to subclass from object any more.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;frenaud@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Python 2 had old style and new style classes. Python 3 has only new
style classes. There is no point to subclass from object any more.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;frenaud@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add basic tests for "migration" end point</title>
<updated>2018-08-27T15:10:32+00:00</updated>
<author>
<name>Stanislav Levin</name>
<email>slev@altlinux.org</email>
</author>
<published>2018-07-17T17:45:56+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=4088b283b4d510fbd8e6d01470c3b30d07d23275'/>
<id>4088b283b4d510fbd8e6d01470c3b30d07d23275</id>
<content type='text'>
Fixes: https://pagure.io/freeipa/issue/7641
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
Reviewed-By: Petr Vobornik &lt;pvoborni@redhat.com&gt;
Reviewed-By: Serhii Tsymbaliuk &lt;stsymbal@localhost.localdomain&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes: https://pagure.io/freeipa/issue/7641
Reviewed-By: Alexander Bokovoy &lt;abokovoy@redhat.com&gt;
Reviewed-By: Petr Vobornik &lt;pvoborni@redhat.com&gt;
Reviewed-By: Serhii Tsymbaliuk &lt;stsymbal@localhost.localdomain&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ipatests/test_ipaserver/test_install/test_installer.py: Drop tempfile import</title>
<updated>2018-08-13T10:35:06+00:00</updated>
<author>
<name>Thomas Woerner</name>
<email>twoerner@redhat.com</email>
</author>
<published>2018-08-08T06:44:32+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=3b8c38ec8b5ce74fe253193c36d33cedb2107f45'/>
<id>3b8c38ec8b5ce74fe253193c36d33cedb2107f45</id>
<content type='text'>
This is not needed anymore due to the removal of the DL0 test

See: https://pagure.io/freeipa/issue/7669
Signed-off-by: Thomas Woerner &lt;twoerner@redhat.com&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This is not needed anymore due to the removal of the DL0 test

See: https://pagure.io/freeipa/issue/7669
Signed-off-by: Thomas Woerner &lt;twoerner@redhat.com&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
