<feed xmlns='http://www.w3.org/2005/Atom'>
<title>freeipa.git/ipatests/test_ipapython, branch coverity</title>
<subtitle>FreeIPA patches</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/'/>
<entry>
<title>Fix session cookies</title>
<updated>2016-07-22T14:30:32+00:00</updated>
<author>
<name>Florence Blanc-Renaud</name>
<email>flo@redhat.com</email>
</author>
<published>2016-07-21T14:54:43+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=bc7eb99a2959980c1abf31f77610cec2f098744b'/>
<id>bc7eb99a2959980c1abf31f77610cec2f098744b</id>
<content type='text'>
The CLI was not using session cookies for communication with IPA API.
The kernel_keyring code was expecting the keyname to be a string, but
in python 2 a unicode was supplied (the key is built using
ipa_session_cookie:%principal and principal is a unicode).

The patch fixes the assertions, allowing to store and retrieve the cookie.
It also adds a test with unicode key name.

https://fedorahosted.org/freeipa/ticket/5984

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The CLI was not using session cookies for communication with IPA API.
The kernel_keyring code was expecting the keyname to be a string, but
in python 2 a unicode was supplied (the key is built using
ipa_session_cookie:%principal and principal is a unicode).

The patch fixes the assertions, allowing to store and retrieve the cookie.
It also adds a test with unicode key name.

https://fedorahosted.org/freeipa/ticket/5984

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Test suite for `ipapython/kerberos.py`</title>
<updated>2016-07-01T07:37:25+00:00</updated>
<author>
<name>Martin Babinsky</name>
<email>mbabinsk@redhat.com</email>
</author>
<published>2016-06-16T12:58:51+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=e6fc8f84d3ad5fc4c030ad592a3d743c02393439'/>
<id>e6fc8f84d3ad5fc4c030ad592a3d743c02393439</id>
<content type='text'>
Low-level unittests checking the correctness principal parsing.

https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: David Kupka &lt;dkupka@redhat.com&gt;
Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Low-level unittests checking the correctness principal parsing.

https://fedorahosted.org/freeipa/ticket/3864

Reviewed-By: David Kupka &lt;dkupka@redhat.com&gt;
Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Pylint: enable reimported check</title>
<updated>2016-03-22T09:20:51+00:00</updated>
<author>
<name>Martin Basti</name>
<email>mbasti@redhat.com</email>
</author>
<published>2016-03-17T18:38:53+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=d46cd5d956d1c03b863bf90d0fd0ff4870448183'/>
<id>d46cd5d956d1c03b863bf90d0fd0ff4870448183</id>
<content type='text'>
Fixes current reimports and enables pylint check for them

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
Reviewed-By: Lukas Slebodnik &lt;lslebodn@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes current reimports and enables pylint check for them

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
Reviewed-By: Lukas Slebodnik &lt;lslebodn@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>pylint: remove bare except</title>
<updated>2016-03-22T09:20:51+00:00</updated>
<author>
<name>Martin Basti</name>
<email>mbasti@redhat.com</email>
</author>
<published>2016-03-11T18:51:07+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=491447cc5ab8c5eff2be57d609201cefb79f7053'/>
<id>491447cc5ab8c5eff2be57d609201cefb79f7053</id>
<content type='text'>
Bare except should not be used.

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
Reviewed-By: Lukas Slebodnik &lt;lslebodn@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Bare except should not be used.

Reviewed-By: Petr Spacek &lt;pspacek@redhat.com&gt;
Reviewed-By: Lukas Slebodnik &lt;lslebodn@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>cookie parser: do not fail on cookie with empty value</title>
<updated>2016-03-01T13:16:08+00:00</updated>
<author>
<name>Petr Vobornik</name>
<email>pvoborni@redhat.com</email>
</author>
<published>2016-02-02T16:04:47+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=25c53ba3fe474a36639d1c5ed30510c921203fdc'/>
<id>25c53ba3fe474a36639d1c5ed30510c921203fdc</id>
<content type='text'>
https://fedorahosted.org/freeipa/ticket/5709

Reviewed-By: Martin Basti &lt;mbasti@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://fedorahosted.org/freeipa/ticket/5709

Reviewed-By: Martin Basti &lt;mbasti@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ipautil.run, kernel_keyring: Encoding fixes for Python 3</title>
<updated>2016-02-17T09:41:29+00:00</updated>
<author>
<name>Petr Viktorin</name>
<email>pviktori@redhat.com</email>
</author>
<published>2016-01-26T12:56:54+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=d3851fd76fd0389775edde0e5337160a7561e247'/>
<id>d3851fd76fd0389775edde0e5337160a7561e247</id>
<content type='text'>
https://fedorahosted.org/freeipa/ticket/5638

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://fedorahosted.org/freeipa/ticket/5638

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>make lint: use config file and plugin for pylint</title>
<updated>2016-02-11T10:06:39+00:00</updated>
<author>
<name>Martin Basti</name>
<email>mbasti@redhat.com</email>
</author>
<published>2016-01-15T15:58:38+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=2ce8921fe69ed58871f8e33e3899ad80dcc28c0e'/>
<id>2ce8921fe69ed58871f8e33e3899ad80dcc28c0e</id>
<content type='text'>
Our custom implementation of pylint checker is often broken by
incompatible change on pylint side. Using supported solutions (config
file, pylint plugins) should avoid this issue.

The plugin adds missing (dynamic) member to classes in abstract syntax
tree generated for pylint, instead of just ignoring missing members and
all sub-members. This should improve pylint detection of typos and
missing members in api. env and test config.

make-lint python script has been removed, to run pylint execute 'make
lint'

https://fedorahosted.org/freeipa/ticket/5615

Reviewed-By: David Kupka &lt;dkupka@redhat.com&gt;
Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Our custom implementation of pylint checker is often broken by
incompatible change on pylint side. Using supported solutions (config
file, pylint plugins) should avoid this issue.

The plugin adds missing (dynamic) member to classes in abstract syntax
tree generated for pylint, instead of just ignoring missing members and
all sub-members. This should improve pylint detection of typos and
missing members in api. env and test config.

make-lint python script has been removed, to run pylint execute 'make
lint'

https://fedorahosted.org/freeipa/ticket/5615

Reviewed-By: David Kupka &lt;dkupka@redhat.com&gt;
Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>ipapython: port p11helper C code to Python</title>
<updated>2016-01-21T09:21:32+00:00</updated>
<author>
<name>Jan Cholasta</name>
<email>jcholast@redhat.com</email>
</author>
<published>2016-01-06T12:10:11+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=500ee7e2b1fdaa9669cf136a380907cfe4f0f225'/>
<id>500ee7e2b1fdaa9669cf136a380907cfe4f0f225</id>
<content type='text'>
This replaces the binary _ipap11helper module with cffi-based Python code.

https://fedorahosted.org/freeipa/ticket/5596

Reviewed-By: Martin Basti &lt;mbasti@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This replaces the binary _ipap11helper module with cffi-based Python code.

https://fedorahosted.org/freeipa/ticket/5596

Reviewed-By: Martin Basti &lt;mbasti@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove wildcard imports</title>
<updated>2015-12-23T06:59:22+00:00</updated>
<author>
<name>Martin Basti</name>
<email>mbasti@redhat.com</email>
</author>
<published>2015-12-16T18:04:20+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=e1192ebd975bc17aa600030eecbaed6660dc7733'/>
<id>e1192ebd975bc17aa600030eecbaed6660dc7733</id>
<content type='text'>
Wildcard imports should not be used.

Check for wildcard imports has been enabled in pylint.
Pylint note: options 'wildcard-import' causes too much false positive
results, so instead it I used 'unused-wildcard-import' option which has almost
the same effect.

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Wildcard imports should not be used.

Check for wildcard imports has been enabled in pylint.
Pylint note: options 'wildcard-import' causes too much false positive
results, so instead it I used 'unused-wildcard-import' option which has almost
the same effect.

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove unused imports</title>
<updated>2015-12-23T06:59:22+00:00</updated>
<author>
<name>Martin Basti</name>
<email>mbasti@redhat.com</email>
</author>
<published>2015-12-16T15:06:03+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=e4075b1fe26a608cd1f3778ee1f655a5f5700c65'/>
<id>e4075b1fe26a608cd1f3778ee1f655a5f5700c65</id>
<content type='text'>
This patch removes unused imports, alse pylint has been configured to
check unused imports.

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch removes unused imports, alse pylint has been configured to
check unused imports.

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
