freeipa.git/ipatests/test_ipalib, branch fix_ber_scanf

Fix wrong use of identity operation

2019-09-04T08:30:07+00:00

Strings should not be compared with the identity operation 'is' or
'is not'.

Fixes: https://pagure.io/freeipa/issue/8057
Signed-off-by: Christian Heimes 
Reviewed-By: Florence Blanc-Renaud

move MSCSTemplate classes to ipalib

2019-07-17T14:58:58+00:00

As we expand the integration tests for external CA functionality, it
is helpful (and avoids duplication) to use the MSCSTemplate*
classes.  These currently live in ipaserver.install.cainstance, but
ipatests is no longer permitted to import from ipaserver (see commit
81714976e5e13131654c78eb734746a20237c933).  So move these classes to
ipalib.

Part of: https://pagure.io/freeipa/issue/7548

Reviewed-By: Florence Blanc-Renaud

Remove deprecated object logger

2019-04-23T10:55:35+00:00

The object logger methods been deprecated for about two years since release
4.6.0. The log manager used to moneky-patch additional log methods like
info(), warning(), and error() into API plugin objects. The methods have
been replaced by calls to module logger objects in 4.6.0.

Remove monkey-patch logger methods, log manager, and its root logger from
ipapython.ipa_log_manager.

Signed-off-by: Christian Heimes 
Reviewed-By: Thomas Woerner

Fix unnecessary usrmerge assumptions

2019-04-17T11:56:05+00:00

On non-usrmerge systems (e.g., Debian), bash, mv, cp, cat, tail,
keyctl, and gzip live in /bin, not /usr/bin.

On usrmerge systems, /bin is a symlink to /usr/bin (or vice versa), so
this has no effect.

Signed-off-by: Robbie Harwood 
Reviewed-By: Alexander Bokovoy 
Reviewed-By: Christian Heimes

Check pager's executable before subprocess.Popen

2018-12-07T13:06:29+00:00

Get the value of `PAGER` environment variable in case it's defined, check the executable, if it exists - use a pager, otherwise - print function.

Fixes: https://pagure.io/freeipa/issue/7746
Reviewed-By: Christian Heimes 
Reviewed-By: Rob Crittenden

Silence comparison-with-itself in tests

2018-11-13T12:37:58+00:00

Test code performs comparison to itself in order to verify __eq__ and
__ne__ implementations.

See: https://pagure.io/freeipa/issue/7758
Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Address inconsistent-return-statements

2018-11-13T12:37:58+00:00

Pylint warns about inconsistent return statements when some paths of a
function return None implicitly. Make all implicit returns either
explicit or raise a proper exception.

See: https://pagure.io/freeipa/issue/7758
Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Py3: Replace six.moves imports

2018-10-05T10:06:19+00:00

Replace six.moves and six.StringIO/BytesIO imports with cannonical
Python 3 packages.

Note: six.moves.input behaves differently than builtin input function.
Therefore I left six.moves.input for now.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes 
Reviewed-By: Fraser Tweedale

Py3: Replace six.integer_types with int

2018-09-27T14:11:18+00:00

In Python 3, six.integer_types is (int,). In most places, the alias can
be simply replaced with int. In other places, it was possible to
simplify the code by unpacking the tuple.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes 
Reviewed-By: Florence Blanc-Renaud

Py3: Remove subclassing from object

2018-09-27T09:49:04+00:00

Python 2 had old style and new style classes. Python 3 has only new
style classes. There is no point to subclass from object any more.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes 
Reviewed-By: Florence Blanc-Renaud