<feed xmlns='http://www.w3.org/2005/Atom'>
<title>freeipa.git/ipatests/test_ipaclient, branch fix_ber_scanf</title>
<subtitle>FreeIPA patches</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/'/>
<entry>
<title>Fix Pytest4.x warning about `message`</title>
<updated>2019-06-19T09:20:14+00:00</updated>
<author>
<name>Stanislav Levin</name>
<email>slev@altlinux.org</email>
</author>
<published>2019-06-17T10:48:44+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=9836511a2b6d7cf48b1a54cb3158e5eac674081a'/>
<id>9836511a2b6d7cf48b1a54cb3158e5eac674081a</id>
<content type='text'>
"message" parameter of pytest.raises is deprecated since Pytest4.1:
```
It is a common mistake to think this parameter will match the
exception message, while in fact it only serves to provide a custom
message in case the pytest.raises check fails.
```

That was the truth for test_unrecognised_attr_type_raises, which has
wrongly checked an exception message.

Fixes: https://pagure.io/freeipa/issue/7981
Signed-off-by: Stanislav Levin &lt;slev@altlinux.org&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"message" parameter of pytest.raises is deprecated since Pytest4.1:
```
It is a common mistake to think this parameter will match the
exception message, while in fact it only serves to provide a custom
message in case the pytest.raises check fails.
```

That was the truth for test_unrecognised_attr_type_raises, which has
wrongly checked an exception message.

Fixes: https://pagure.io/freeipa/issue/7981
Signed-off-by: Stanislav Levin &lt;slev@altlinux.org&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Add test case for configure_openldap_conf</title>
<updated>2019-03-29T10:35:26+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2019-01-14T16:25:28+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=a376b6136c1180e19fca76a3753c40cdba18993f'/>
<id>a376b6136c1180e19fca76a3753c40cdba18993f</id>
<content type='text'>
IPAChangeConf doesn't handle lines with mixed assignment values
correctly.

See: https://pagure.io/freeipa/issue/7838
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Thomas Woerner &lt;twoerner@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
IPAChangeConf doesn't handle lines with mixed assignment values
correctly.

See: https://pagure.io/freeipa/issue/7838
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Thomas Woerner &lt;twoerner@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Py3: Remove subclassing from object</title>
<updated>2018-09-27T09:49:04+00:00</updated>
<author>
<name>Christian Heimes</name>
<email>cheimes@redhat.com</email>
</author>
<published>2018-09-26T09:59:50+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=b431e9b684df11c811892bd9d2a5711355f0076e'/>
<id>b431e9b684df11c811892bd9d2a5711355f0076e</id>
<content type='text'>
Python 2 had old style and new style classes. Python 3 has only new
style classes. There is no point to subclass from object any more.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;frenaud@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Python 2 had old style and new style classes. Python 3 has only new
style classes. There is no point to subclass from object any more.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes &lt;cheimes@redhat.com&gt;
Reviewed-By: Florence Blanc-Renaud &lt;frenaud@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>csrgen: fix when attribute shortname is lower case</title>
<updated>2018-04-25T12:41:12+00:00</updated>
<author>
<name>Fraser Tweedale</name>
<email>ftweedal@redhat.com</email>
</author>
<published>2018-04-16T06:11:05+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=852618fd6529fbdd7b03077fae37c6fbbe45b51b'/>
<id>852618fd6529fbdd7b03077fae37c6fbbe45b51b</id>
<content type='text'>
OpenSSL requires attribute short names ("CN", "O", etc) to be in
upper case, otherwise it fails to add the attribute.  This can be
triggered when FreeIPA has been installed with --subject-base
containing a lower-case attribute shortname (e.g.
--subject-base="o=Red Hat").

Explicitly convert the attribute type string to an OID
(ASN1_OBJECT *).  If that fails, upper-case the type string and try
again.

Add some tests for the required behaviour.

Fixes: https://pagure.io/freeipa/issue/7496
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
OpenSSL requires attribute short names ("CN", "O", etc) to be in
upper case, otherwise it fails to add the attribute.  This can be
triggered when FreeIPA has been installed with --subject-base
containing a lower-case attribute shortname (e.g.
--subject-base="o=Red Hat").

Explicitly convert the attribute type string to an OID
(ASN1_OBJECT *).  If that fails, upper-case the type string and try
again.

Add some tests for the required behaviour.

Fixes: https://pagure.io/freeipa/issue/7496
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>csrgen: Change to pure openssl config format (no script)</title>
<updated>2017-04-03T07:46:30+00:00</updated>
<author>
<name>Ben Lipton</name>
<email>blipton@redhat.com</email>
</author>
<published>2017-03-21T21:23:46+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=136c6c3e2a4f77a27f435efd4a1cd95c9e089314'/>
<id>136c6c3e2a4f77a27f435efd4a1cd95c9e089314</id>
<content type='text'>
https://pagure.io/freeipa/issue/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
https://pagure.io/freeipa/issue/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>csrgen: Remove helper abstraction</title>
<updated>2017-04-03T07:46:30+00:00</updated>
<author>
<name>Ben Lipton</name>
<email>blipton@redhat.com</email>
</author>
<published>2017-03-21T16:21:30+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=5420e9cfbe7803808b6e26d2dae64f2a6a50149a'/>
<id>5420e9cfbe7803808b6e26d2dae64f2a6a50149a</id>
<content type='text'>
All requests now use the OpenSSL formatter. However, we keep Formatter
a separate class so that it can be changed out for tests.

https://pagure.io/freeipa/issue/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
All requests now use the OpenSSL formatter. However, we keep Formatter
a separate class so that it can be changed out for tests.

https://pagure.io/freeipa/issue/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>test_csrgen: adjusted comparison test scripts for CSRGenerator</title>
<updated>2017-03-07T12:18:14+00:00</updated>
<author>
<name>Michal Reznik</name>
<email>mreznik@redhat.com</email>
</author>
<published>2017-03-03T10:17:17+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=83e2c2b65eeb5a3aa4a59c0535e9177aac5e4637'/>
<id>83e2c2b65eeb5a3aa4a59c0535e9177aac5e4637</id>
<content type='text'>
Commit ada91c2 introduced changes in "csrgen/templates/openssl_base.tmpl"
which broke the following 2 tests:

    test_CSRGenerator.test_userCert_OpenSSL
    test_CSRGenerator.test_caIPAserviceCert_OpenSSL

The tests use files caIPAserviceCert_openssl.sh and userCert_openssl.sh
as expected scripts in order to compare scripts generated by CSRGenerator.
E.g. as other parameter was introduced we are now not checking with
"if [[ $# -ne 2 ]]" but rather with if "[[ $# -lt 2 ]]".

https://pagure.io/freeipa/issue/6724

Reviewed-By: Milan Kubik &lt;mkubik@redhat.com&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Commit ada91c2 introduced changes in "csrgen/templates/openssl_base.tmpl"
which broke the following 2 tests:

    test_CSRGenerator.test_userCert_OpenSSL
    test_CSRGenerator.test_caIPAserviceCert_OpenSSL

The tests use files caIPAserviceCert_openssl.sh and userCert_openssl.sh
as expected scripts in order to compare scripts generated by CSRGenerator.
E.g. as other parameter was introduced we are now not checking with
"if [[ $# -ne 2 ]]" but rather with if "[[ $# -lt 2 ]]".

https://pagure.io/freeipa/issue/6724

Reviewed-By: Milan Kubik &lt;mkubik@redhat.com&gt;
Reviewed-By: Christian Heimes &lt;cheimes@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>tests: Add tests for CSR autogeneration</title>
<updated>2017-01-31T09:20:28+00:00</updated>
<author>
<name>Ben Lipton</name>
<email>blipton@redhat.com</email>
</author>
<published>2016-09-08T22:29:46+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/freeipa.git/commit/?id=a26cf0d7910dd4c0a4da08682b4be8d3d94ba520'/>
<id>a26cf0d7910dd4c0a4da08682b4be8d3d94ba520</id>
<content type='text'>
This patch also contains some code changes to make the code easier to
test and to make the tests pass.

https://fedorahosted.org/freeipa/ticket/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This patch also contains some code changes to make the code easier to
test and to make the tests pass.

https://fedorahosted.org/freeipa/ticket/4899

Reviewed-By: Jan Cholasta &lt;jcholast@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
