freeipa.git/ipatests/test_install, branch fix_ber_scanf

Move ipachangeconf from ipaclient.install to ipapython

2019-08-29T02:15:50+00:00

This will let us call it from ipaplatform.

Mark the original location as deprecated.

Reviewed-By: Francois Cami 
Reviewed-By: Rob Crittenden

Make use of the single configuration point for the default shells

2019-06-19T09:39:51+00:00

For now all the default shells of users and admin are hardcoded in
different parts of the project. This makes it impossible to run the
test suite against the setup, which has the default shell differed
from '/bin/sh'.

The single configuration point for the shell of users and admin is
added to overcome this limitation.

Fixes: https://pagure.io/freeipa/issue/7978
Signed-off-by: Stanislav Levin 
Reviewed-By: Christian Heimes

Use new LDAPClient constructors

2019-02-05T13:39:13+00:00

Replace get_ldap_uri() + LDAPClient() with new LDAPClient constructors
like LDAPClient.from_realm().

Some places now use LDAPI with external bind instead of LDAP with simple
bind. Although the FQDN *should* resolve to 127.0.0.1 / [::1], there is
no hard guarantee. The draft
https://tools.ietf.org/html/draft-west-let-localhost-be-localhost-04#section-5.1
specifies that applications must verify that the resulting IP is a
loopback API. LDAPI is always local and a bit more efficient, too.

The simple_bind() method also prevents the caller from sending a
password over an insecure line.

Signed-off-by: Christian Heimes 
Reviewed-By: Rob Crittenden

ipa-client-install: Update how comments are added by ipachangeconf

2018-07-05T17:42:43+00:00

Due to how 'openldap-client' parses its configuration files this patch
changes how comments are added, moving them to the line above instead
of appending to the same line.

IPA doesn't want to break existing configuration, if a value already
exists it adds a comment to the modified setting and a note about that
on the line above.

New settings will be added without any note.

Issue: https://pagure.io/freeipa/issue/5202

Signed-off-by: Armando Neto 
Reviewed-By: Rob Crittenden

Refuse PORT, HOST in /etc/openldap/ldap.conf

2018-05-29T13:30:37+00:00

OpenLDAP has deprecated PORT and HOST stanzes in ldap.conf. The presence
of either option causes FreeIPA installation to fail. Refuse
installation when a deprecated and unsupported option is present.

Fixes: https://pagure.io/freeipa/issue/7418
Signed-off-by: Christian Heimes 
Reviewed-By: Florence Blanc-Renaud

Add absolute_import future imports

2018-04-20T07:43:37+00:00

Add absolute_import from __future__ so that pylint
does not fail and to achieve python3 behavior in
python2.

Reviewed-By: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Replace nose with unittest and pytest

2017-12-12T15:16:58+00:00

* Replace raise nose.SkipTest with raise unittest.SkipTest
* Replace nose.tools.assert_equal(a, b) with assert a == b
* Replace nose.tools.raises with pytest.raises
* Convert @raises decorator to pytest.raises() but just for relevant
  lines.
* Remove nose dependency

I left the nose_compat pytest plugin in place. It can be removed in
another request in case it is no longer used.

https://pagure.io/freeipa/issue/7301

Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Add marker needs_ipaapi and option to skip tests

2017-12-11T19:40:06+00:00

The new marker needs_ipaapi is used to mark tests that needs an
initialized API (ipalib.api) or some sort of other API services (running
LDAP server) to work. Some packages use api.Command or api.Backend on
module level. They are not marked but rather skipped entirely.

A new option ``skip-ipaapi`` is added to skip all API based tests. With
the option, only simple unit tests are executed. As of now, freeIPA
contains more than 500 unit tests that can be executed in about 5
seconds.

Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Use os.path.isfile() and isdir()

2017-10-20T10:27:19+00:00

Replace custom file_exists() and dir_exists() functions with proper
functions from Python's stdlib.

The change also gets rid of pylint's invalid bad-python3-import error,
https://github.com/PyCQA/pylint/issues/1565

Signed-off-by: Christian Heimes 
Reviewed-By: Stanislav Laznicka

pytest 3.x compatibility

2017-03-27T16:03:14+00:00

pytest 3.x does no longer support plain pytest.skip() on module level.

Signed-off-by: Christian Heimes 
Reviewed-By: Martin Basti