freeipa.git/ipapython/dnssec/localhsm.py, branch webui_isolate

ipapython: move dnssec, p11helper and secrets to ipaserver

2016-11-29T13:50:51+00:00

The dnssec and secrets subpackages and the p11helper module depend on
ipaplatform.

Move them to ipaserver as they are used only on the server.

https://fedorahosted.org/freeipa/ticket/6474

Reviewed-By: Stanislav Laznicka

do not use keys() method when iterating through dictionaries

2016-10-12T08:38:52+00:00

pylint-1.6.4-1.fc26.noarch reports "C0201(consider-iterating-dictionary)" when
building FreeIPA, we have to fix these errors

https://fedorahosted.org/freeipa/ticket/6391

Reviewed-By: Martin Basti

Pylint: fix the rest of unused local variables

2016-10-11T14:50:32+00:00

Reviewed-By: Pavel Vomacka

Pylint: enable check for unused-variables

2016-09-27T11:35:58+00:00

Unused variables may:
* make code less readable
* create dead code
* potentialy hide issues/errors

Enabled check should prevent to leave unused variable in code

Check is locally disabled for modules that fix is not clear or easy or have too many occurences of
unused variables

Reviewed-By: Florence Blanc-Renaud 
Reviewed-By: Stanislav Laznicka

ipapython: port p11helper C code to Python

2016-01-21T09:21:32+00:00

This replaces the binary _ipap11helper module with cffi-based Python code.

https://fedorahosted.org/freeipa/ticket/5596

Reviewed-By: Martin Basti

Remove unused imports

2015-12-23T06:59:22+00:00

This patch removes unused imports, alse pylint has been configured to
check unused imports.

Reviewed-By: Jan Cholasta

Use the print function

2015-09-01T09:42:01+00:00

In Python 3, `print` is no longer a statement. Call it as a function
everywhere, and include the future import to remove the statement
in Python 2 code as well.

Reviewed-By: Christian Heimes 
Reviewed-By: Jan Cholasta

Use Python3-compatible dict method names

2015-09-01T09:42:01+00:00

Python 2 has keys()/values()/items(), which return lists,
iterkeys()/itervalues()/iteritems(), which return iterators,
and viewkeys()/viewvalues()/viewitems() which return views.

Python 3 has only keys()/values()/items(), which return views.
To get iterators, one can use iter() or a for loop/comprehension;
for lists there's the list() constructor.

When iterating through the entire dict, without modifying the dict,
 the difference between Python 2's items() and iteritems() is
negligible, especially on small dicts (the main overhead is
extra memory, not CPU time). In the interest of simpler code,
this patch changes many instances of iteritems() to items(),
iterkeys() to keys() etc.

In other cases, helpers like six.itervalues are used.

Reviewed-By: Christian Heimes 
Reviewed-By: Jan Cholasta

Use absolute imports

2015-08-12T16:17:23+00:00

In Python 3, implicit relative imports will not be supported.
Use fully-qualified imports everywhere.

Reviewed-By: Tomas Babej

ipapython: Fix incorrect python shebangs

2015-01-26T12:03:24+00:00

Make sure shebangs explicitly reference python2.

Reviewed-By: Martin Basti