freeipa.git/ipalib/plugins/aci.py, branch webui_isolate

ipalib: move server-side plugins to ipaserver

2016-06-03T07:00:34+00:00

Move the remaining plugin code from ipalib.plugins to ipaserver.plugins.

Remove the now unused ipalib.plugins package.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka

ipalib: use relative imports for cross-plugin imports

2016-05-25T14:06:26+00:00

This will make it possible to move the plugin modules between ipalib,
ipaclient and ipaserver without having to change the imports.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka

ipalib: remove the unused `csv` argument of Param

2016-05-25T14:06:26+00:00

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka

ipalib: make optional positional command arguments actually optional

2016-05-25T14:06:26+00:00

Fix several plugins not to assume optional positional arguments have a
value of None when not specified.

https://fedorahosted.org/freeipa/ticket/4739

Reviewed-By: David Kupka

Pylint: remove unnecessary-semicolon

2016-03-22T09:20:51+00:00

Reviewed-By: Petr Spacek 
Reviewed-By: Lukas Slebodnik

Remove wildcard imports

2015-12-23T06:59:22+00:00

Wildcard imports should not be used.

Check for wildcard imports has been enabled in pylint.
Pylint note: options 'wildcard-import' causes too much false positive
results, so instead it I used 'unused-wildcard-import' option which has almost
the same effect.

Reviewed-By: Jan Cholasta

Alias "unicode" to "str" under Python 3

2015-09-17T09:08:43+00:00

The six way of doing this is to replace all occurences of "unicode"
with "six.text_type". However, "unicode" is non-ambiguous and
(arguably) easier to read. Also, using it makes the patches smaller,
which should help with backporting.

Reviewed-By: Petr Viktorin

Modernize use of range()

2015-09-01T09:42:01+00:00

In Python 3, range() behaves like the old xrange().
The difference between range() and xrange() is usually not significant,
especially if the whole result is iterated over.

Convert xrange() usage to range() for small ranges.
Use modern idioms in a few other uses of range().

Reviewed-By: Christian Heimes 
Reviewed-By: Jan Cholasta

Use Python3-compatible dict method names

2015-09-01T09:42:01+00:00

Python 2 has keys()/values()/items(), which return lists,
iterkeys()/itervalues()/iteritems(), which return iterators,
and viewkeys()/viewvalues()/viewitems() which return views.

Python 3 has only keys()/values()/items(), which return views.
To get iterators, one can use iter() or a for loop/comprehension;
for lists there's the list() constructor.

When iterating through the entire dict, without modifying the dict,
 the difference between Python 2's items() and iteritems() is
negligible, especially on small dicts (the main overhead is
extra memory, not CPU time). In the interest of simpler code,
this patch changes many instances of iteritems() to items(),
iterkeys() to keys() etc.

In other cases, helpers like six.itervalues are used.

Reviewed-By: Christian Heimes 
Reviewed-By: Jan Cholasta

Modernize 'except' clauses

2015-08-12T16:17:23+00:00

The 'as' syntax works from Python 2 on, and Python 3 will
drop the "comma" syntax.

Reviewed-By: Tomas Babej