freeipa.git/install/ui/src/freeipa, branch fixlogout

WebUI: fix incorrect behavior of ESC button on combobox

2017-02-17T16:50:32+00:00

When combobox is opened then ESC key should close it. There was a bug
that ESC key closed also the dialog. It was caused by bad keyboard event
handling. The CB was closed by keydown event and the dialog by keyup.

Therefore the propagating of keyup and keydown event is stopped when CB
is opened (when the event is fired on CB element).

https://fedorahosted.org/freeipa/ticket/6388

Reviewed-By: Petr Vobornik 
Reviewed-By: Martin Basti

WebUI: add default on_cancel function in adder_dialog

2017-02-17T16:50:32+00:00

Adder dialog is mixed with confirmation_mixin. That mixin calls on_cancel method
when closing dialog using ESC key. Previously the on_cancel method
was not defined, therefore dialog was not correctly closed. This was the root
cause of the bug, that adder dialog cannot be opened after closing it using ESC.

Now the default function for on_cancel is dialog.close. So dialog
is correctly closed.

https://fedorahosted.org/freeipa/ticket/6388

Reviewed-By: Petr Vobornik 
Reviewed-By: Martin Basti

Coverity: removed useless semicolon which ends statement earlier

2017-01-18T08:15:54+00:00

Reviewed-By: Tomas Krizek

Coverity: Fix possibility of access to attribute of undefined

2017-01-18T08:15:54+00:00

Reviewed-By: Tomas Krizek

Change activity text while loading metadata

2017-01-05T18:13:37+00:00

After log in into webui there was 'Authenticating' sign even during loading metadata.
Now while data are loading there is 'Loading data' text. This change requires new global
topic 'set-activity' of activity widget. So for now there is possibility to change
every activity string during running phase just by publishing 'set-activity' topic
and setting new text as first parameter.

Part of: https://fedorahosted.org/freeipa/ticket/6144

Reviewed-By: Petr Vobornik

Refactoring of rpc module

2017-01-05T18:13:37+00:00

The rpc module is now separated from display layer.

There are two new global topics:
- 'rpc-start' for showing the widget which indicates execution of rpc calls
- 'rpc-end' for hiding the widget which indicates execution of rpc calls.
These two global topics replace the original methods IPA.display_activity_icon() and
IPA.hide_activity_icon().

There is also new property of a command (notify_globally), which allows to turn off the widget
which indicates network activity. Instead of classic activity indicator there can be
called custom function at the beginning and at the end of network activity.

There are also changes in internal communication in rpc.js module. There are four new
events, two for calling on_success and on_error methods and two for calling custom functions
at the beginning and at the end of network activity.

https://fedorahosted.org/freeipa/ticket/6144

Reviewed-By: Petr Vobornik

WebUI: Hide incorrectly shown buttons on hosts tab in ID Views

2016-12-12T17:30:10+00:00

There was missing default value for evaluator adapter.
In that case the adapter variable could be undefined and
it crashes on building adapter. Therefore it did not
evaluate all evaluators. That is the reason why 'Delete'
and 'Add' buttons were incorrectly shown.
Default value is now set to empty object.

https://fedorahosted.org/freeipa/ticket/6546

Reviewed-By: Petr Vobornik

Coverity - null pointer dereference

2016-11-10T17:58:38+00:00

Add check which protect from calling method of null.

Reviewed-By: Petr Vobornik

Coverity - accessing attribute of variable which can point to null

2016-11-10T17:58:38+00:00

Added check whether variable is pointing to null or not.

Reviewed-By: Petr Vobornik

Coverity - opens dialog which might not be created

2016-11-10T17:58:38+00:00

Check whether dialog object is created before opening it.

Reviewed-By: Petr Vobornik