freeipa.git/daemons/ipa-otpd, branch fix_ber_scanf

Py3: Replace six.moves imports

2018-10-05T10:06:19+00:00

Replace six.moves and six.StringIO/BytesIO imports with cannonical
Python 3 packages.

Note: six.moves.input behaves differently than builtin input function.
Therefore I left six.moves.input for now.

See: https://pagure.io/freeipa/issue/7715
Signed-off-by: Christian Heimes 
Reviewed-By: Fraser Tweedale

Add cmocka unit tests for ipa otpd queue code

2018-08-31T19:01:46+00:00

Reviewed-By: Florence Blanc-Renaud

Clear next field when returnining list elements in queue.c

2018-08-31T19:01:46+00:00

The ipa-otpd code occasionally removes elements from one queue,
inspects and modifies them, and then inserts them into
another (possibly identical, possibly different) queue.  When the next
pointer isn't cleared, this can result in element membership in both
queues, leading to double frees, or even self-referential elements,
causing infinite loops at traversal time.

Rather than eliminating the pattern, make it safe by clearing the next
field any time an element enters or exits a queue.

Related https://pagure.io/freeipa/issue/7262

Reviewed-By: Florence Blanc-Renaud

Cleanup shebang and executable bit

2018-07-05T17:46:42+00:00

- Add missing executable bits to all scripts
- Remove executable bits from all files that are not scripts,
  e.g. js, html, and Python libraries.
- Remove Python shebang from all Python library files.

It's frown upon to have executable library files in site-packages.

Signed-off-by: Christian Heimes 
Reviewed-By: Armando Neto

Fix elements not being removed in otpd_queue_pop_msgid()

2018-05-31T15:53:25+00:00

If the element being removed were not the queue head,
otpd_queue_pop_msgid() would not actually remove the element, leading
to potential double frees and request replays.

Reviewed-By: Alexander Bokovoy 
Reviewed-By: Stanislav Laznicka

Have all the scripts run in python 3 by default

2018-02-15T17:43:12+00:00

The Python 3 refactoring effort is finishing, it should be safe
to turn all scripts to run in Python 3 by default.

https://pagure.io/freeipa/issue/4985

Reviewed-By: Christian Heimes

ipa-otpd.socket.in: Use a platform specific value for KDC service file

2017-04-12T14:17:51+00:00

https://pagure.io/freeipa/issue/6845

Reviewed-By: Christian Heimes 
Reviewed-By: Tomas Krizek

Use RemoveOnStop to cleanup systemd sockets

2017-02-17T14:19:07+00:00

Reviewed-By: Christian Heimes

Add main guards to a couple of Python scripts

2016-11-24T15:35:43+00:00

Signed-off-by: Christian Heimes 
Reviewed-By: Martin Basti

Build: add missing KRB5_LIBS to daemons/ipa-otpd

2016-10-18T08:47:59+00:00

It was working accidentally because krb5 libs are part of OPENLDAP_LIBS.

Reviewed-By: Martin Basti 
Reviewed-By: Alexander Bokovoy