freeipa.git/daemons/dnssec, branch fix_ber_scanf

Replace PYTHONSHEBANG with valid shebang

2019-06-24T07:35:57+00:00

Replace the @PYTHONSHEBANG@ substitution with a valid #!/usr/bin/python3
shebang. This turns Python .in files into valid Python files. The files
can now be checked with pylint and IDEs recognize the files as Python
files.

The shebang is still replaced with "#!$(PYTHON) -E" to support
platform-python.

Related: https://pagure.io/freeipa/issue/7984
Signed-off-by: Christian Heimes 
Reviewed-By: Francois Cami

Fix `inconsistent-return-statements` in ipa-dnskeysync-replica

2019-04-24T06:10:45+00:00

This problem was discovered by pylint.

Fixes: https://pagure.io/freeipa/issue/7921
Signed-off-by: Stanislav Levin 
Reviewed-By: Christian Heimes

Improve error handling in DNSSEC helpers

2019-04-10T09:21:25+00:00

* ipa-dnskeysyncd now handles CONNECT_ERROR during bind
* ipa-dnskeysyncd no longer logs full traceback on connection error.
* ipa-dnskeysync-replica now handles SERVER_DOWN/CONNECT_ERROR
  exceptions and turns them into pretty error messages.

Fixes: https://pagure.io/freeipa/issue/7905
Signed-off-by: Christian Heimes 
Reviewed-By: Oleg Kozlov

Generate scripts from templates

2018-08-23T12:49:06+00:00

Python scripts are now generated from templates. The scripts are marked
as nodist (no distribution) but install targets. The templates for the
scripts are extra distribution data, no installation (noinst).

Fixes: https://pagure.io/freeipa/issue/7680
Signed-off-by: Christian Heimes 
Reviewed-By: Alexander Bokovoy

Rename Python scripts and add dynamic shebang

2018-08-23T12:49:06+00:00

All Python scripts are now generated from a template with a dynamic
shebang.

ipatests/i18n.py is no longer an executable script with shebang. The
module is not executed as script directly, but rather as

    $(PYTHON) ipatests/i18n.py

Fixes: https://pagure.io/freeipa/issue/7680
All Python scripts are now template files with a dynamic shebang line.

Reviewed-By: Alexander Bokovoy

Have all the scripts run in python 3 by default

2018-02-15T17:43:12+00:00

The Python 3 refactoring effort is finishing, it should be safe
to turn all scripts to run in Python 3 by default.

https://pagure.io/freeipa/issue/4985

Reviewed-By: Christian Heimes

DNSSEC code cleanup

2018-02-07T16:27:11+00:00

Replace assert with proper check and exception.

Signed-off-by: Christian Heimes 
Reviewed-By: Stanislav Laznicka

Decode ODS commands

2018-02-07T16:27:11+00:00

ODS commands are ASCII strings, but socket.recv() returns bytes and
socket.send() expects bytes. Encode/decode values properly.

Signed-off-by: Christian Heimes 
Reviewed-By: Stanislav Laznicka

py3 dnssec: convert hexlify to str

2018-02-07T16:27:11+00:00

hexlify returns bytes and needs to be casted to string before
printing it out.

Related: https://pagure.io/freeipa/issue/4985

Signed-off-by: Tomas Krizek 
Reviewed-By: Stanislav Laznicka

Give ODS socket a bit of time

2018-01-23T20:54:04+00:00

ipa-ods-exporter uses systemd socket activation. The script uses
select() to check if the socket is readable. A timeout of 0 is a bit too
aggressive. Sometimes select() doesn't consider the systemd socket as
readable. This causes ODS to fail silently

A timeout of one second seems to remove the problem. A proper error code
also signals that something went wrong.

Closes: https://pagure.io/freeipa/issue/7378
Signed-off-by: Christian Heimes 
Reviewed-By: Rob Crittenden