freeipa.git/client/ipa-client-install, branch webui_isolate

install: migrate client install to the new class hierarchy

2016-11-11T11:17:25+00:00

Migrate ipa-client-install from the custom script to the new installer
class hierarchy classes.

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Martin Basti

client: use exceptions instead of return states

2016-11-11T11:13:56+00:00

Python has builtin exceptions which can be used very well to handling
errors in python instead of returning error states (C style)

Exception will allow better client-server integration in future

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: move install part to else branch

2016-11-11T11:13:56+00:00

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: move install cleanup from ipa-client-install to module

2016-11-11T11:13:56+00:00

Cleanup should be part of installation function

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: move clean CCACHE to module

2016-11-11T11:13:56+00:00

According 04b8575c52410bb6d31e0e55f1cf431d7cc9c7c3 cleaning CCACHE is
needed after installation. This commit moves this cleanup from
ipa-client-install to client.install() function

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: fix script execution

2016-11-11T11:13:56+00:00

if __name__ == "__main__" should be first instead of try block. We want
execute it only when file was executed as script

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: Remove useless except in ipa-client-install

2016-11-11T11:13:56+00:00

SystemExit is raised by sys.exit() so catching and reraising it again is
wasting of resources

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: move custom env variable into client module

2016-11-11T11:13:56+00:00

There is no need to have env as parameter because this is used only
once, so it can eb safely moved to client.py module

NOTE: PATH should be overwritten to safe values before we execute any
command
https://www.securecoding.cert.org/confluence/display/c/ENV03-C.+Sanitize+the+environment+when+invoking+external+programs

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: extract checks from uninstall to uninstall_check

2016-11-11T11:13:56+00:00

Checks if uninstallation is possible should be moved to uninstall_check

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka

client: move checks to client.install_check

2016-11-11T11:13:56+00:00

Move checks from ipa-client-install to clien.install_check

https://fedorahosted.org/freeipa/ticket/6392

Reviewed-By: Stanislav Laznicka