From a0c764a36f2f432e6063de84be6f6af7e96ec159 Mon Sep 17 00:00:00 2001 From: Sumit Bose Date: Wed, 10 Feb 2016 15:15:41 +0100 Subject: Just return NULL if tevent_req_create() fails MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In general we just return NULL if tevent_req_create() fails because there is nothing we can do with the request anyway. Especially tevent_req_error() should not be called because it tries to dereference req. Reviewed-by: Pavel Březina --- src/responder/sudo/sudosrv_dp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/responder/sudo/sudosrv_dp.c') diff --git a/src/responder/sudo/sudosrv_dp.c b/src/responder/sudo/sudosrv_dp.c index 95595fba2..3c3ac8b75 100644 --- a/src/responder/sudo/sudosrv_dp.c +++ b/src/responder/sudo/sudosrv_dp.c @@ -62,8 +62,7 @@ sss_dp_get_sudoers_send(TALLOC_CTX *mem_ctx, req = tevent_req_create(mem_ctx, &state, struct sss_dp_req_state); if (!req) { - ret = ENOMEM; - goto error; + return NULL; } if (!dom) { -- cgit