From c03214d427ea43e7bf8255ccc79faa905c89f7f6 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Fri, 8 Apr 2016 16:33:00 +0200 Subject: LDAP: make it clear that sdap_add_incomplete_groups operates on sysdb names Just provides a more descriptive name of a function parameter. Reviewed-by: Sumit Bose --- src/providers/ldap/sdap_async_initgroups.c | 10 +++++----- src/providers/ldap/sdap_async_private.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/providers') diff --git a/src/providers/ldap/sdap_async_initgroups.c b/src/providers/ldap/sdap_async_initgroups.c index 8d9fcc459..b4000f3b4 100644 --- a/src/providers/ldap/sdap_async_initgroups.c +++ b/src/providers/ldap/sdap_async_initgroups.c @@ -32,7 +32,7 @@ errno_t sdap_add_incomplete_groups(struct sysdb_ctx *sysdb, struct sss_domain_info *domain, struct sdap_options *opts, - char **groupnames, + char **sysdb_groupnames, struct sysdb_attrs **ldap_groups, int ldap_groups_count) { @@ -66,16 +66,16 @@ errno_t sdap_add_incomplete_groups(struct sysdb_ctx *sysdb, } mi = 0; - for (i=0; groupnames[i]; i++) { - ret = sysdb_search_group_by_name(tmp_ctx, domain, groupnames[i], NULL, + for (i=0; sysdb_groupnames[i]; i++) { + ret = sysdb_search_group_by_name(tmp_ctx, domain, sysdb_groupnames[i], NULL, &msg); if (ret == EOK) { continue; } else if (ret == ENOENT) { - missing[mi] = talloc_strdup(missing, groupnames[i]); + missing[mi] = talloc_strdup(missing, sysdb_groupnames[i]); DEBUG(SSSDBG_TRACE_LIBS, "Group #%d [%s][%s] is not cached, " \ "need to add a fake entry\n", - i, groupnames[i], missing[mi]); + i, sysdb_groupnames[i], missing[mi]); mi++; continue; } else if (ret != ENOENT) { diff --git a/src/providers/ldap/sdap_async_private.h b/src/providers/ldap/sdap_async_private.h index 9cde6f5df..f09ddb71f 100644 --- a/src/providers/ldap/sdap_async_private.h +++ b/src/providers/ldap/sdap_async_private.h @@ -147,7 +147,7 @@ sdap_nested_group_lookup_external_recv(TALLOC_CTX *mem_ctx, errno_t sdap_add_incomplete_groups(struct sysdb_ctx *sysdb, struct sss_domain_info *domain, struct sdap_options *opts, - char **groupnames, + char **sysdb_groupnames, struct sysdb_attrs **ldap_groups, int ldap_groups_count); -- cgit