From 83a79d93035c2d75a1941f3b54426119174044a0 Mon Sep 17 00:00:00 2001 From: Pavel Březina Date: Sun, 15 May 2016 20:48:13 +0200 Subject: RESPONDER: New interface for client registration MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is just a beginning of new responder interface to data provider and it is just to make the client registration work. It needs further improvement. The idea is to take the existing interface and make it work better with further extensions of data provider. The current interface has several disadvantages such as it is originally build only for account requests and doesn't take different set of output parameters. It also doesn't work well with integration into tevent-made responders. Reviewed-by: Sumit Bose Reviewed-by: Jakub Hrozek Reviewed-by: Lukáš Slebodník --- src/providers/data_provider.h | 2 -- src/providers/dp_auth_util.c | 36 ------------------------------------ 2 files changed, 38 deletions(-) (limited to 'src/providers') diff --git a/src/providers/data_provider.h b/src/providers/data_provider.h index f52295ae4..b0b6876d9 100644 --- a/src/providers/data_provider.h +++ b/src/providers/data_provider.h @@ -227,8 +227,6 @@ bool dp_pack_pam_response(DBusMessage *msg, struct pam_data *pd); bool dp_unpack_pam_response(DBusMessage *msg, struct pam_data *pd, DBusError *dbus_error); -int dp_common_send_id(struct sbus_connection *conn, uint16_t version, - const char *name); void dp_id_callback(DBusPendingCall *pending, void *ptr); /* from dp_sbus.c */ diff --git a/src/providers/dp_auth_util.c b/src/providers/dp_auth_util.c index 8e261ef5e..8c09299b1 100644 --- a/src/providers/dp_auth_util.c +++ b/src/providers/dp_auth_util.c @@ -385,39 +385,3 @@ done: dbus_pending_call_unref(pending); dbus_message_unref(reply); } - -int dp_common_send_id(struct sbus_connection *conn, uint16_t version, - const char *name) -{ - DBusMessage *msg; - dbus_bool_t ret; - int retval; - - /* create the message */ - msg = dbus_message_new_method_call(NULL, - DP_PATH, - DATA_PROVIDER_IFACE, - DATA_PROVIDER_IFACE_REGISTERSERVICE); - if (msg == NULL) { - DEBUG(SSSDBG_FATAL_FAILURE, "Out of memory?!\n"); - return ENOMEM; - } - - DEBUG(SSSDBG_CONF_SETTINGS, "Sending ID to DP: (%d,%s)\n", - version, name); - - ret = dbus_message_append_args(msg, - DBUS_TYPE_UINT16, &version, - DBUS_TYPE_STRING, &name, - DBUS_TYPE_INVALID); - if (!ret) { - DEBUG(SSSDBG_CRIT_FAILURE, "Failed to build message\n"); - return EIO; - } - - retval = sbus_conn_send(conn, msg, 30000, dp_id_callback, NULL, NULL); - - dbus_message_unref(msg); - return retval; -} - -- cgit