From 76ba5d2b8d95ec444c124dd9a44275ce685fb648 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 11 Oct 2014 21:38:32 +0200 Subject: GPO: Do not use output argument if function failed deny_size and allow_size were initialized in function parse_policy_setting_value (output argument). If function parse_policy_setting_value fails then output arguments will not initialized and will be used uninitialized in debug macro. Reviewed-by: Jakub Hrozek --- src/providers/ad/ad_gpo.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/providers/ad/ad_gpo.c') diff --git a/src/providers/ad/ad_gpo.c b/src/providers/ad/ad_gpo.c index 2d8ba82da..3f5df75c5 100644 --- a/src/providers/ad/ad_gpo.c +++ b/src/providers/ad/ad_gpo.c @@ -1431,8 +1431,8 @@ ad_gpo_perform_hbac_processing(TALLOC_CTX *mem_ctx, &allow_sids, &allow_size); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, - "parse_policy_setting_value failed; allow_size %d: %d\n", - allow_size, ret); + "parse_policy_setting_value failed for key %s: [%d](%s)\n", + allow_key, ret, sss_strerror(ret)); ret = EINVAL; goto done; } @@ -1441,8 +1441,8 @@ ad_gpo_perform_hbac_processing(TALLOC_CTX *mem_ctx, &deny_sids, &deny_size); if (ret != EOK) { DEBUG(SSSDBG_OP_FAILURE, - "parse_policy_setting_value failed; deny_size %d: %d\n", - deny_size, ret); + "parse_policy_setting_value failed for key %s: [%d](%s)\n", + deny_key, ret, sss_strerror(ret)); ret = EINVAL; goto done; } -- cgit