Fix warning: equality comparison with extraneous parentheses

Example of warning:
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  error: equality comparison with extraneous parentheses
  [-Werror,-Wparentheses-equality]
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
         ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: remove extraneous parentheses around the comparison
  to silence this warning
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
        ~             ^                 ~
src/sss_client/libwbclient/wbc_pwd_sssd.c:246:23:
  note: use '=' to turn this equality comparison into an assignment
    if (((wbc_status) == WBC_ERR_SUCCESS)) {
                      ^~
                      =

The reason is definition of some macros which were used in if conditions.

Reviewed-by: Michal Židek <mzidek@redhat.com>

4 files changed, 11 insertions, 11 deletions

diff --git a/src/providers/proxy/proxy_auth.c b/src/providers/proxy/proxy_auth.c
index a901f0f17..d85320cf6 100644
--- a/src/providers/proxy/proxy_auth.c
+++ b/src/providers/proxy/proxy_auth.c
@@ -365,7 +365,7 @@ static void pc_init_sig_handler(struct tevent_context *ev,
                       "child [%d] was stopped by signal [%d].\n", ret,
                           WSTOPSIG(child_status));
             }
-            if (WIFCONTINUED(child_status)) {
+            if (WIFCONTINUED(child_status) == true) {
                 DEBUG(SSSDBG_CRIT_FAILURE,
                       "child [%d] was resumed by delivery of SIGCONT.\n",
                           ret);
@@ -522,7 +522,7 @@ static void proxy_child_sig_handler(struct tevent_context *ev,
             DEBUG(SSSDBG_CONF_SETTINGS,
                   "child [%d] exited with status [%d].\n", ret,
                       WEXITSTATUS(child_status));
-        } else if (WIFSIGNALED(child_status)) {
+        } else if (WIFSIGNALED(child_status) == true) {
             DEBUG(SSSDBG_CONF_SETTINGS,
                   "child [%d] was terminated by signal [%d].\n", ret,
                       WTERMSIG(child_status));
@@ -532,7 +532,7 @@ static void proxy_child_sig_handler(struct tevent_context *ev,
                       "child [%d] was stopped by signal [%d].\n", ret,
                           WSTOPSIG(child_status));
             }
-            if (WIFCONTINUED(child_status)) {
+            if (WIFCONTINUED(child_status) == true) {
                 DEBUG(SSSDBG_CRIT_FAILURE,
                       "child [%d] was resumed by delivery of SIGCONT.\n",
                           ret);
diff --git a/src/python/pyhbac.c b/src/python/pyhbac.c
index c46f7c6b3..f3aaa60f0 100644
--- a/src/python/pyhbac.c
+++ b/src/python/pyhbac.c
@@ -794,7 +794,7 @@ hbac_rule_set_enabled(HbacRuleObject *self, PyObject *enabled, void *closure)
 
         Py_DECREF(utf8_str);
         return 0;
-    } else if (PyBool_Check(enabled)) {
+    } else if (PyBool_Check(enabled) == true) {
         self->enabled = (enabled == Py_True);
         return 0;
     } else if (PYNUMBER_CHECK(enabled)) {
diff --git a/src/sss_client/libwbclient/wbc_pwd_sssd.c b/src/sss_client/libwbclient/wbc_pwd_sssd.c
index 6cdea1c03..08c3b8637 100644
--- a/src/sss_client/libwbclient/wbc_pwd_sssd.c
+++ b/src/sss_client/libwbclient/wbc_pwd_sssd.c
@@ -243,7 +243,7 @@ wbcErr wbcGetpwnam(const char *name, struct passwd **pwd)
 
     status = ctx->getpwnam_r(name, &lpwd, buffer, buflen, &nss_errno);
     wbc_status = nss_to_wbc(status);
-    if (WBC_ERROR_IS_OK(wbc_status)) {
+    if (WBC_ERROR_IS_OK(wbc_status) == true) {
         wbc_status = copy_pwd(&lpwd, pwd);
     }
 
@@ -278,7 +278,7 @@ wbcErr wbcGetpwuid(uid_t uid, struct passwd **pwd)
 
     status = ctx->getpwuid_r(uid, &lpwd, buffer, buflen, &nss_errno);
     wbc_status = nss_to_wbc(status);
-    if (WBC_ERROR_IS_OK(wbc_status)) {
+    if (WBC_ERROR_IS_OK(wbc_status) == true) {
         wbc_status = copy_pwd(&lpwd, pwd);
     }
 
@@ -401,7 +401,7 @@ wbcErr wbcGetgrnam(const char *name, struct group **grp)
         memset(grp, 0, sizeof(struct group));
         status = ctx->getgrnam_r(name, &lgrp, buffer, buflen, &nss_errno);
         wbc_status = nss_to_wbc(status);
-        if (WBC_ERROR_IS_OK(wbc_status)) {
+        if (WBC_ERROR_IS_OK(wbc_status) == true) {
             wbc_status = copy_grp(&lgrp, grp);
         }
     } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \
@@ -445,7 +445,7 @@ wbcErr wbcGetgrgid(gid_t gid, struct group **grp)
         memset(grp, 0, sizeof(struct group));
         status = ctx->getgrgid_r(gid, &lgrp, buffer, buflen, &nss_errno);
         wbc_status = nss_to_wbc(status);
-        if (WBC_ERROR_IS_OK(wbc_status)) {
+        if (WBC_ERROR_IS_OK(wbc_status) == true) {
             wbc_status = copy_grp(&lgrp, grp);
         }
     } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \
@@ -514,7 +514,7 @@ wbcErr wbcGetpwent(struct passwd **pwd)
 
     status = ctx->getpwent_r(&lpwd, buffer, buflen, &nss_errno);
     wbc_status = nss_to_wbc(status);
-    if (WBC_ERROR_IS_OK(wbc_status)) {
+    if (WBC_ERROR_IS_OK(wbc_status) == true) {
         wbc_status = copy_pwd(&lpwd, pwd);
     }
 
@@ -588,7 +588,7 @@ wbcErr wbcGetgrent(struct group **grp)
         memset(grp, 0, sizeof(struct group));
         status = ctx->getgrent_r(&lgrp, buffer, buflen, &nss_errno);
         wbc_status = nss_to_wbc(status);
-        if (WBC_ERROR_IS_OK(wbc_status)) {
+        if (WBC_ERROR_IS_OK(wbc_status) == true) {
             wbc_status = copy_grp(&lgrp, grp);
         }
     } while (status == NSS_STATUS_TRYAGAIN && nss_errno == ERANGE \
diff --git a/src/util/child_common.c b/src/util/child_common.c
index b1af02337..a6131cd20 100644
--- a/src/util/child_common.c
+++ b/src/util/child_common.c
@@ -568,7 +568,7 @@ static void child_sig_handler(struct tevent_context *ev,
                       "child [%d] was stopped by signal [%d].\n", ret,
                           WSTOPSIG(child_ctx->child_status));
             }
-            if (WIFCONTINUED(child_ctx->child_status)) {
+            if (WIFCONTINUED(child_ctx->child_status) == true) {
                 DEBUG(SSSDBG_TRACE_LIBS,
                       "child [%d] was resumed by delivery of SIGCONT.\n",
                           ret);