LDAP: Decorate the hot paths in the LDAP provider with systemtap probes

During performance analysis, the LDAP provider and especially its nested
group code proved to be the place where we spend the most time during
account requests. Therefore, I decorated the LDAP provider with
systemtap probes to be able to observe where the time is spent.

The code allows passing of search properties (base, filter, ...) from
marks to probes. Where applicable, the probes pass on these arguments to
functions and build a human-readable string representation.

Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>

2 files changed, 286 insertions, 0 deletions

diff --git a/src/systemtap/sssd.stp.in b/src/systemtap/sssd.stp.in
index 2bd45aeb8..199916383 100644
--- a/src/systemtap/sssd.stp.in
+++ b/src/systemtap/sssd.stp.in
@@ -30,3 +30,227 @@ probe sssd_transaction_cancel = process("@libdir@/sssd/libsss_util.so").mark("sy
                        $$name,
                        nesting);
 }
+
+# LDAP search probes
+probe sdap_search_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_get_generic_ext_send")
+{
+    base = user_string($arg1);
+    scope = $arg2;
+    filter = user_string($arg3);
+
+    probestr = sprintf("-> search base [%s] scope [%d] filter [%s]",
+                       base, scope, filter);
+}
+
+probe sdap_search_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_get_generic_ext_recv")
+{
+    base = user_string($arg1);
+    scope = $arg2;
+    filter = user_string($arg3);
+
+    probestr = sprintf("<- search base [%s] scope [%d] filter [%s]",
+                       base, scope, filter);
+}
+
+probe sdap_deref_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_deref_search_send")
+{
+    base_dn = user_string($arg1);
+    deref_attr = user_string($arg2);
+
+    probestr = sprintf("-> (%s)(base_dn=[%s],deref_attr=[%s])",
+                       $$name, base_dn, deref_attr);
+}
+
+probe sdap_deref_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_deref_search_recv")
+{
+    base_dn = user_string($arg1);
+    deref_attr = user_string($arg2);
+
+    probestr = sprintf("-> (%s)(base_dn=[%s],deref_attr=[%s])",
+                       $$name, base_dn, deref_attr);
+}
+
+# LDAP account request probes
+probe sdap_acct_req_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_acct_req_send")
+{
+    entry_type = $arg1;
+    filter_type = $arg2;
+    filter_value = user_string($arg3);
+    extra_value = user_string($arg4);
+}
+
+probe sdap_acct_req_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_acct_req_recv")
+{
+    entry_type = $arg1;
+    filter_type = $arg2;
+    filter_value = user_string($arg3);
+    extra_value = user_string($arg4);
+}
+
+# LDAP user search probes
+probe sdap_search_user_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_search_user_send")
+{
+    filter = user_string($arg1);
+}
+
+probe sdap_search_user_save_begin = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_search_user_save_begin")
+{
+    filter = user_string($arg1);
+}
+
+probe sdap_search_user_save_end = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_search_user_save_end")
+{
+    filter = user_string($arg1);
+}
+
+probe sdap_search_user_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_search_user_recv")
+{
+    filter = user_string($arg1);
+}
+
+# LDAP group search probes
+probe sdap_nested_group_populate_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_populate_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_populate_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_populate_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_save_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_save_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_save_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_save_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_user_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_user_send")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_user_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_user_recv")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_group_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_group_send")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_group_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_group_recv")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_unknown_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_unknown_send")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_lookup_unknown_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_lookup_unknown_recv")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_deref_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_deref_send")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_deref_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_deref_recv")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_deref_process_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_deref_process_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_deref_process_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_deref_process_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_send")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_recv")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_process_send = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_process_send")
+{
+    orig_dn = user_string($arg1);
+
+    probestr = sprintf("-> %s(orig_dn=[%s])",
+                       $$name, orig_dn);
+}
+
+probe sdap_nested_group_process_split_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_process_split_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_process_split_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_process_split_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_check_cache_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_check_cache_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_check_cache_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_check_cache_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_sysdb_search_users_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_sysdb_search_users_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_sysdb_search_users_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_sysdb_search_users_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_sysdb_search_groups_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_sysdb_search_groups_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_sysdb_search_groups_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_sysdb_search_groups_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_populate_search_users_pre = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_populate_search_users_pre")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_populate_search_users_post = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_populate_search_users_post")
+{
+    # No arguments
+}
+
+probe sdap_nested_group_process_recv = process("@libdir@/sssd/libsss_ldap_common.so").mark("sdap_nested_group_process_recv")
+{
+    orig_dn = user_string($arg1);
+
+    probestr = sprintf("-> %s(orig_dn=[%s])",
+                       $$name, orig_dn);
+}
diff --git a/src/systemtap/sssd_probes.d b/src/systemtap/sssd_probes.d
index f4890ddfd..33339b415 100644
--- a/src/systemtap/sssd_probes.d
+++ b/src/systemtap/sssd_probes.d
@@ -3,4 +3,66 @@ provider sssd {
     probe sysdb_transaction_commit_before(int nesting);
     probe sysdb_transaction_commit_after(int nesting);
     probe sysdb_transaction_cancel(int nesting);
+
+    probe sdap_acct_req_send(int entry_type,
+                             int filter_type,
+                             char *filter_value,
+                             char *extra_value);
+    probe sdap_acct_req_recv(int entry_type,
+                             int filter_type,
+                             char *filter_value,
+                             char *extra_value);
+
+    probe sdap_search_user_send(const char *filter);
+    probe sdap_search_user_save_begin(const char *filter);
+    probe sdap_search_user_save_end(const char *filter);
+    probe sdap_search_user_recv(const char *filter);
+
+    probe sdap_get_generic_ext_send(const char *base, int scope, const char *filter);
+    probe sdap_get_generic_ext_recv(const char *base, int scope, const char *filter);
+
+    probe sdap_deref_search_send(const char *base_dn, const char *deref_attr);
+    probe sdap_deref_search_recv(const char *base_dn, const char *deref_attr);
+
+    probe sdap_nested_group_populate_pre();
+    probe sdap_nested_group_populate_post();
+
+    probe sdap_nested_group_save_pre();
+    probe sdap_nested_group_save_post();
+
+    probe sdap_nested_group_lookup_user_send();
+    probe sdap_nested_group_lookup_user_recv();
+
+    probe sdap_nested_group_lookup_group_send();
+    probe sdap_nested_group_lookup_group_recv();
+
+    probe sdap_nested_group_lookup_unknown_send();
+    probe sdap_nested_group_lookup_unknown_recv();
+
+    probe sdap_nested_group_deref_send();
+    probe sdap_nested_group_deref_process_pre();
+    probe sdap_nested_group_deref_process_post();
+    probe sdap_nested_group_deref_recv();
+
+    probe sdap_save_group_pre();
+    probe sdap_save_group_post();
+
+    probe sdap_save_grpmem_pre();
+    probe sdap_save_grpmem_post();
+
+    probe sdap_nested_group_send();
+    probe sdap_nested_group_recv();
+
+    probe sdap_nested_group_process_send(const char *orig_dn);
+    probe sdap_nested_group_process_split_pre();
+    probe sdap_nested_group_process_split_post();
+    probe sdap_nested_group_process_recv(const char *orig_dn);
+    probe sdap_nested_group_check_cache_pre();
+    probe sdap_nested_group_check_cache_post();
+    probe sdap_nested_group_sysdb_search_users_pre();
+    probe sdap_nested_group_sysdb_search_users_post();
+    probe sdap_nested_group_sysdb_search_groups_pre();
+    probe sdap_nested_group_sysdb_search_groups_post();
+    probe sdap_nested_group_populate_search_users_pre();
+    probe sdap_nested_group_populate_search_users_post();
 }