summaryrefslogtreecommitdiffstats
path: root/src/responder
diff options
context:
space:
mode:
authorJakub Hrozek <jhrozek@redhat.com>2016-05-10 12:24:44 +0200
committerJakub Hrozek <jhrozek@redhat.com>2016-05-10 17:08:24 +0200
commite8474ac0be7e81c0ca54eb09e2fef42595602945 (patch)
treeaff116409cf0777aa4da6d925cb294194ee36354 /src/responder
parentc30b7a1931211fdcae0564551a7625cc4f6dee9f (diff)
downloadsssd-e8474ac0be7e81c0ca54eb09e2fef42595602945.tar.gz
sssd-e8474ac0be7e81c0ca54eb09e2fef42595602945.tar.xz
sssd-e8474ac0be7e81c0ca54eb09e2fef42595602945.zip
IFP: Do not crash on invalid arguments to GetUserAttr
Reviewed-by: Pavel Březina <pbrezina@redhat.com>
Diffstat (limited to 'src/responder')
-rw-r--r--src/responder/ifp/ifpsrv_cmd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/responder/ifp/ifpsrv_cmd.c b/src/responder/ifp/ifpsrv_cmd.c
index 399e83e02..2c0ceb817 100644
--- a/src/responder/ifp/ifpsrv_cmd.c
+++ b/src/responder/ifp/ifpsrv_cmd.c
@@ -83,7 +83,7 @@ int ifp_user_get_attr(struct sbus_request *dbus_req, void *data)
ret = ifp_user_get_attr_unpack_msg(attr_req);
if (ret != EOK) {
- return ret; /* handled internally */
+ return ret; /* internal error */
}
DEBUG(SSSDBG_FUNC_DATA,
@@ -117,7 +117,7 @@ ifp_user_get_attr_unpack_msg(struct ifp_attr_req *attr_req)
DBUS_TYPE_INVALID);
if (parsed == false) {
DEBUG(SSSDBG_OP_FAILURE, "Could not parse arguments\n");
- return EOK; /* handled */
+ return ERR_SBUS_REQUEST_HANDLED;
}
/* Copy the attributes to maintain memory hierarchy with talloc */