diff options
| author | Fabiano Fidêncio <fidencio@redhat.com> | 2016-05-25 21:12:18 +0200 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2016-05-31 13:06:50 +0200 |
| commit | a928f7a6bd7681db6e26cba3eb7da22d14288737 (patch) | |
| tree | 7996403758dea9a8c5c43157a17bd29801a7709d /src/db/sysdb_services.c | |
| parent | 5b1e73bc40a55f2095660423a2a4623a93de1ef8 (diff) | |
| download | sssd-a928f7a6bd7681db6e26cba3eb7da22d14288737.tar.gz sssd-a928f7a6bd7681db6e26cba3eb7da22d14288737.tar.xz sssd-a928f7a6bd7681db6e26cba3eb7da22d14288737.zip | |
sysdb: add sysdb_{add,replace,delete}_string()
As the add_string() convenience can add, replace or delete a string
according to the operation received as its argument, some confusion can
easily happen due to its misleading name.
In order to improve the explicitness of our code, let's introduce
sysdb_add_string(), sysdb_replace_string() and sysdb_delete_string().
These new functions are basically wrappers of add_string() (now
sysdb_ldb_msg_string_helper()), calling it using the proper flag
according to each function.
Any code previously using add_string() is now adapted to use these brand
new functions.
Resolves: https://fedorahosted.org/sssd/ticket/1656
Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
Reviewed-by: Petr Cech <pcech@redhat.com>
Diffstat (limited to 'src/db/sysdb_services.c')
| -rw-r--r-- | src/db/sysdb_services.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/db/sysdb_services.c b/src/db/sysdb_services.c index 37f7ec5ff..20c88b724 100644 --- a/src/db/sysdb_services.c +++ b/src/db/sysdb_services.c @@ -460,13 +460,11 @@ sysdb_svc_add(TALLOC_CTX *mem_ctx, } /* Objectclass */ - ret = add_string(msg, LDB_FLAG_MOD_ADD, - SYSDB_OBJECTCLASS, SYSDB_SVC_CLASS); + ret = sysdb_add_string(msg, SYSDB_OBJECTCLASS, SYSDB_SVC_CLASS); if (ret != EOK) goto done; /* Set the primary name */ - ret = add_string(msg, LDB_FLAG_MOD_ADD, - SYSDB_NAME, primary_name); + ret = sysdb_add_string(msg, SYSDB_NAME, primary_name); if (ret != EOK) goto done; /* Set the port number */ @@ -623,8 +621,7 @@ sysdb_svc_remove_alias(struct sysdb_ctx *sysdb, msg->dn = dn; - ret = add_string(msg, SYSDB_MOD_DEL, - SYSDB_NAME_ALIAS, alias); + ret = sysdb_delete_string(msg, SYSDB_NAME_ALIAS, alias); if (ret != EOK) goto done; lret = ldb_modify(sysdb->ldb, msg); |