summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLukas Slebodnik <lslebodn@redhat.com>2016-07-04 09:53:06 +0200
committerLukas Slebodnik <lslebodn@redhat.com>2016-07-04 13:47:01 +0200
commit90e5684e8e623d9b616e38300acc6eed51a28229 (patch)
treeeb15cf15f8f72b682f95205ccd30a83eb0d70e77
parenta2407fc21be3e9e5006cc575aae01ed1216138db (diff)
downloadsssd-90e5684e8e623d9b616e38300acc6eed51a28229.tar.gz
sssd-90e5684e8e623d9b616e38300acc6eed51a28229.tar.xz
sssd-90e5684e8e623d9b616e38300acc6eed51a28229.zip
IPA: Fix uninitialized pointer read (UNINIT)
We try to release sdap_handle in the function sdap_cli_connect_recv. Therefore we might try to release memory which does not belong to us due to uninitialized pointer. 2070 if (gsh) { 6. read_parm: Reading a parameter value. 2071 if (*gsh) { 2072 talloc_zfree(*gsh); 2073 } Found by Coverity Reviewed-by: Fabiano FidĂȘncio <fidencio@redhat.com>
-rw-r--r--src/providers/ipa/ipa_auth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/providers/ipa/ipa_auth.c b/src/providers/ipa/ipa_auth.c
index ad0a89bfe..5fee03bae 100644
--- a/src/providers/ipa/ipa_auth.c
+++ b/src/providers/ipa/ipa_auth.c
@@ -312,7 +312,7 @@ static void ipa_pam_auth_handler_connect_done(struct tevent_req *subreq)
{
struct ipa_pam_auth_handler_state *state;
struct tevent_req *req;
- struct sdap_handle *sh;
+ struct sdap_handle *sh = NULL;
const char *attrs[] = {SYSDB_ORIG_DN, NULL};
struct ldb_message *msg;
const char *dn;